Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing_month() in utils.R #347

Open
sarabodach opened this issue Jun 27, 2024 · 0 comments
Open

missing_month() in utils.R #347

sarabodach opened this issue Jun 27, 2024 · 0 comments
Labels
question Further information is requested

Comments

@sarabodach
Copy link
Collaborator

          > @sarabodach Can you elaborate on "Include tests for NA" here? Do you want a unit test to see how the code handles empty dates? Since we are specifically looking for suspicious instances where year and day are present I assume this check doent care much if the date is fully missing

Maybe this would be a unit test for the function that is used across? This is based on an assumption that the string is "--" - i.e.,

missing_month <- function(date) { substr(date, 5, 7) == "---" }

I wonder if we can consider expanding the assumption that the string might be reported as "UNK" or "UN" or something else? But that would be a separate issue. For the original checkbox issue - the NA part doesn't apply as I had originally thought.

Originally posted by @sarabodach in #333 (comment)

@sarabodach sarabodach added the question Further information is requested label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant