Exposing NTContaine>>tags: is not good

[Ducasse]

NTContainer defines ensureTagNamed:.

NTContainer >> ensureTagNamed: aString
	"Add a tag if it not already present"
	^ self tags
		  detect: [ :n | n tagName = aString ]
		  ifNone: [ self addTagNamed: aString ]

It ensures that there is not two tags witht the same name.
Now the tags is an orderedCollection and not a Set.
So offering the tags: accessor means that the user could have duplicated tags.

[Ducasse]

@moufort
Is my analysis correct?

[Ducasse]

We should rename it as rawTags: and indicate in the comment that this is a private method.
And we should categorise it into a private protocol.

[Ducasse]

Fix my PR I fixed this one.

[moufort]

Yes, your analysis was correct