✅ Switch from JSHint to ESLint

Author: macdonst

.eslintrc.yml

@@ -0,0 +1,10 @@
+root: true
+extends: 'semistandard'
+rules:
+  indent:
+    - error
+    - 4
+  camelcase: off
+  padded-blocks: off
+  operator-linebreak: off
+  no-throw-literal: off

.jshintrc

@@ -28,10 +28,22 @@
   "author": "Adobe PhoneGap Team",
   "license": "Apache-2.0",
   "scripts": {
-    "test": "jasmine-node --color spec"
+    "test": "npm run eslint && jasmine-node --color spec",
+    "eslint": "node node_modules/eslint/bin/eslint www && node node_modules/eslint/bin/eslint src && node node_modules/eslint/bin/eslint tests"
   },
   "devDependencies": {
-    "jasmine-node": "1.14.5",
-    "pluginpub": "^0.0.6"
+    "eslint-config-semistandard": "^11.0.0",
+    "eslint-config-standard": "^10.2.1",
+    "eslint-plugin-import": "^2.7.0",
+    "eslint-plugin-node": "^5.1.1",
+    "eslint-plugin-promise": "^3.5.0",
+    "eslint-plugin-standard": "^3.0.1",
+    "husky": "^0.10.1",
+    "eslint": "^4.0.0",
+    "jasmine-node": "^1.14.5",
+    "pluginpub": "^0.0.8"
+  },
+  "dependencies": {
+    "eslint": "^4.4.1"
   }
 }

package.json

@@ -0,0 +1,83 @@
+/* global cordova:true */
+
+/*!
+ * Module dependencies.
+ */
+
+/**
+ * cordova.js for node.
+ *
+ * Think of this as cordova-node, which would be simliar to cordova-android
+ * or cordova-browser. The purpose of this module is to enable testing
+ * of a plugin's JavaScript interface.
+ *
+ * When this module is first required, it will insert a global cordova
+ * instance, which can hijack cordova-specific commands within the pluin's
+ * implementation.
+ *
+ * Remember to require this module before the plugin that you want to test.
+ *
+ * Example:
+ *
+ *     var cordova = require('./helper/cordova'),
+ *         myPlugin = require('../www/myPlugin');
+ */
+
+module.exports = global.cordova = cordova = {
+
+    /**
+     * cordova.require Mock.
+     *
+     * Hijacks all cordova.requires. By default, it returns an empty function.
+     * You can define your own implementation of each required module before
+     * or after it has been required.
+     *
+     * See `cordova.required` to learn how to add your own module implemtnation.
+     */
+
+    require: function(moduleId) {
+        // define a default function if it doesn't exist
+        if (!cordova.required[moduleId]) {
+            cordova.required[moduleId] = function() {};
+        }
+        // create a new module mapping between the module Id and cordova.required.
+        return new ModuleMap(moduleId);
+    },
+
+    /**
+     * Cordova module implementations.
+     *
+     * A key-value hash, where the key is the module such as 'cordova/exec'
+     * and the value is the function or object returned.
+     *
+     * For example:
+     *
+     *     var exec = require('cordova/exec');
+     *
+     * Will map to:
+     *
+     *     cordova.required['cordova/exec'];
+     */
+
+    required: {
+        // populated at runtime
+    }
+};
+
+/**
+ * Module Mapper.
+ *
+ * Returns a function that when executed will lookup the implementation
+ * in cordova.required[id].
+ *
+ * @param {String} moduleId is the module name/path, such as 'cordova/exec'
+ * @return {Function}.
+ */
+
+function ModuleMap(moduleId) {
+    return function() {
+        // lookup and execute the module's mock implementation, passing
+        // in any parameters that were provided.
+        return cordova.required[moduleId].apply(this, arguments);
+    };
+}

spec/helper/cordova.js

@@ -19,33 +19,33 @@
  *
  */
 /* jshint jasmine: true */
-/* global navigator, done */
-exports.defineAutoTests = function() {
+/* global navigator, describe, it, expect, fail */
+exports.defineAutoTests = function () {
 
-    describe('Plugin conforms to w3c specs', function() {
+    describe('Plugin conforms to w3c specs', function () {
 
-        it("navigator.mediaDevices should exist", function() {
+        it('navigator.mediaDevices should exist', function () {
             expect(navigator.mediaDevices).toBeDefined();
             expect(typeof navigator.mediaDevices).toBe('object');
             expect(navigator.mediaDevices.enumerateDevices).toBeDefined();
             expect(typeof navigator.mediaDevices.enumerateDevices).toBe('function');
             // does not return ondevicechnge as defined
-            //expect(navigator.mediaDevices.ondevicechange).toBeDefined();
+            // expect(navigator.mediaDevices.ondevicechange).toBeDefined();
             expect(navigator.mediaDevices.getSupportedConstraints).toBeDefined();
             expect(typeof navigator.mediaDevices.getSupportedConstraints).toBe('function');
             expect(navigator.mediaDevices.getUserMedia).toBeDefined();
             expect(typeof navigator.mediaDevices.getUserMedia).toBe('function');
 
         });
 
-        it('enumerateDevices should return a promise with attributes', function(done) {
+        it('enumerateDevices should return a promise with attributes', function (done) {
             try {
                 var promise = navigator.mediaDevices.enumerateDevices();
                 expect(typeof promise.then).toBe('function');
-                promise.then(function(info) {
+                promise.then(function (info) {
                     expect(info).toBeDefined();
                     expect(typeof info).toBe('object');
-                    info.forEach(function(device) {
+                    info.forEach(function (device) {
                         expect(device.deviceId).toBeDefined();
                         expect(device.kind).toBeDefined();
                         expect(device.label).toBeDefined();
@@ -56,7 +56,7 @@ exports.defineAutoTests = function() {
                         expect(typeof device.groupId).toBe('string');
                     });
                     done();
-                }, function(err) {
+                }, function (err) {
                     expect(err).toBeDefined();
                     fail(err);
                     done();
@@ -68,7 +68,7 @@ exports.defineAutoTests = function() {
 
         });
 
-        it('getSupportedConstraints should return a promise with attributes', function() {
+        it('getSupportedConstraints should return a promise with attributes', function () {
 
             var support = navigator.mediaDevices.getSupportedConstraints();
             expect(support.width).toBeDefined();
@@ -100,14 +100,14 @@ exports.defineAutoTests = function() {
 
         });
 
-        it('getUserMedia should return a promise with attributes', function(done) {
+        it('getUserMedia should return a promise with attributes', function (done) {
             try {
                 var constraints = {
                     video: true
                 };
                 var promise = navigator.mediaDevices.getUserMedia(constraints);
                 expect(typeof promise.then).toBe('function');
-                promise.then(function(media) {
+                promise.then(function (media) {
                     expect(media).toBeDefined();
                     expect(typeof media).toBe('object');
                     // media.getworks with android studio
@@ -150,7 +150,7 @@ exports.defineAutoTests = function() {
                     // expect(videoTracks[0].getCapabilities).toBeDefined();
                     // expect(videoTracks[0].getConstraints).toBeDefined();
                     // expect(videoTracks[0].getSettings).toBeDefined();
-                    //expect(videoTracks[0].applyConstraints).toBeDefined();
+                    // expect(videoTracks[0].applyConstraints).toBeDefined();
 
                     var audioTracks = media.getAudioTracks();
                     expect(audioTracks[0].label).toBeDefined();
@@ -164,23 +164,19 @@ exports.defineAutoTests = function() {
                     expect(audioTracks[0].onended).toBeDefined();
                     // expect(audioTracks[0].stop).toBeDefined();
 
-                    var tracks = media.getTracks();
-                    expect(tracks[0].label).toBeDefined();
-                    expect(tracks[0].kind).toBeDefined();
-                    expect(tracks[0].id).toBeDefined();
-                    expect(tracks[0].enabled).toBeDefined();
-                    expect(tracks[0].muted).toBeDefined();
-                    expect(tracks[0].onmute).toBeDefined();
-                    expect(tracks[0].onunmute).toBeDefined();
-                    expect(tracks[0].readyState).toBeDefined();
-                    expect(tracks[0].onended).toBeDefined();
+                    var tracks2 = media.getTracks();
+                    expect(tracks2[0].label).toBeDefined();
+                    expect(tracks2[0].kind).toBeDefined();
+                    expect(tracks2[0].id).toBeDefined();
+                    expect(tracks2[0].enabled).toBeDefined();
+                    expect(tracks2[0].muted).toBeDefined();
+                    expect(tracks2[0].onmute).toBeDefined();
+                    expect(tracks2[0].onunmute).toBeDefined();
+                    expect(tracks2[0].readyState).toBeDefined();
+                    expect(tracks2[0].onended).toBeDefined();
                     // expect(tracks[0].stop).toBeDefined();
-
-
-
-
                     done();
-                }, function(err) {
+                }, function (err) {
                     expect(err).toBeDefined();
                     fail(err);
                     done();

tests/tests.js

@@ -21,34 +21,33 @@
 */
 /* globals window, navigator, cordova, Promise */
 
-var exec = cordova.require('cordova/exec'),
-    utils = cordova.require('cordova/utils');
+var exec = cordova.require('cordova/exec');
 
 var mediaDevices = {
     nativeMediaDevices: navigator.mediaDevices
 };
 
-mediaDevices.getSupportedConstraints = function() {
+mediaDevices.getSupportedConstraints = function () {
     return this.nativeMediaDevices.getSupportedConstraints();
 };
 
-mediaDevices.enumerateDevices = function() {
+mediaDevices.enumerateDevices = function () {
     return this.nativeMediaDevices.enumerateDevices();
 };
 
-mediaDevices.getUserMedia = function(constraints) {
+mediaDevices.getUserMedia = function (constraints) {
     var mediaDevice = this.nativeMediaDevices;
 
-    return new Promise(function(resolve, reject) {
-        var success = function() {
+    return new Promise(function (resolve, reject) {
+        var success = function () {
             mediaDevice.getUserMedia(constraints)
-                .then(function(stream) {
+                .then(function (stream) {
                     resolve(stream);
-                }).catch(function(error) {
+                }).catch(function (error) {
                     reject(error);
                 });
         };
-        var fail = function(error) {
+        var fail = function (error) {
             reject(error);
         };
         exec(success, fail, 'MediaStreams', 'getUserMedia', [constraints]);

www/android/MediaDevices.js

@@ -19,10 +19,9 @@
  *
 */
 /* globals Promise, cordova, MediaStream */
-var exec = cordova.require('cordova/exec'),
-    utils = cordova.require('cordova/utils'),
-    flagConstraints = true,
-    flagDevices = true;
+var exec = cordova.require('cordova/exec');
+var flagConstraints = true;
+var flagDevices = true;
 
 var mediaDevices = {
     _devices: null
@@ -44,8 +43,8 @@ var supportedConstraints = {
     'groupId': true
 };
 
-mediaDevices.getSupportedConstraints = function() {
-    var success = function(constraints) {
+mediaDevices.getSupportedConstraints = function () {
+    var success = function (constraints) {
         console.log('constraints: ' + JSON.stringify(constraints));
         supportedConstraints = constraints;
     };
@@ -59,10 +58,10 @@ mediaDevices.getSupportedConstraints = function() {
     return supportedConstraints;
 };
 
-mediaDevices.enumerateDevices = function() {
+mediaDevices.enumerateDevices = function () {
     var that = this;
-    return new Promise(function(resolve, reject) {
-        var success = function(device) {
+    return new Promise(function (resolve, reject) {
+        var success = function (device) {
             flagDevices = false;
             console.log('success ' + device.devices);
             that._devices = device.devices;
@@ -77,10 +76,9 @@ mediaDevices.enumerateDevices = function() {
     });
 };
 
-
-mediaDevices.getUserMedia = function(constraints) {
-    return new Promise(function(resolve, reject) {
-        var success = function(getMediaTracks) {
+mediaDevices.getUserMedia = function (constraints) {
+    return new Promise(function (resolve, reject) {
+        var success = function (getMediaTracks) {
             console.log('mediatrack' + getMediaTracks);
             var stream = new MediaStream(getMediaTracks);
             resolve(stream);
@@ -90,5 +88,4 @@ mediaDevices.getUserMedia = function(constraints) {
     });
 };
 
-
 module.exports = mediaDevices;