Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student solution AST parser service #186

Open
AydinHassan opened this issue Dec 5, 2020 · 0 comments
Open

Student solution AST parser service #186

AydinHassan opened this issue Dec 5, 2020 · 0 comments

Comments

@AydinHassan
Copy link
Member

Quite a few checks parse the students solution so we could end up reading from disk and parsing (slow)

It would be good to have a service which can be called to get the AST, the service can then cache the AST if anything else needs it to.

It would also reduce repeated error checking code, eg, did it parse correctly, and constructing failures.

It would probably look something like:

class AstService {
    public function parse(Input $input): array
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant