Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check code for errors and warning #4

Open
mikeymike opened this issue Oct 1, 2015 · 0 comments
Open

Check code for errors and warning #4

mikeymike opened this issue Oct 1, 2015 · 0 comments
Assignees

Comments

@mikeymike
Copy link
Member

A users solution may trigger errors and warnings. This would be contained in the output and would obviously fail the StdOutCheck. However, could we provide more meaningful feedback?

PhpErrorCheck

We could grep the output for PHP Notice: and PHP Warning. This seems a bit flaky as that could be valid output.
We could lint the file first, check if it's valid PHP code, then parse the file and add in some code, like an error-handler which would exit with a non-zero error code.

@AydinHassan AydinHassan self-assigned this Oct 1, 2015
@AydinHassan AydinHassan added this to the 1.0.0 milestone Oct 1, 2015
@AydinHassan AydinHassan removed this from the 1.0.0 milestone Jan 27, 2016
devnuhl added a commit to devnuhl/php-workshop that referenced this issue May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants