Generated arginfo header files: remove empty zend_function_entry arrays #15705
Conversation
When a class (or enum) has no methods, rather than using an array that only contains `ZEND_FE_END`, use `NULL` for the functions. The implementation of class registration for internal classes, `do_register_internal_class()` in zend_API.c, already skips classes where the functions are `NULL`. By removing these unneeded arrays, we can reduce the size of the header files, while also removing an unneeded call to zend_register_functions() for each internal class with no extra methods.
DanielEScherzer
requested review from
nielsdos,
bukka,
Girgias,
devnexen,
TimWolla,
zeriyoshi,
NattyNarwhal,
SakiTakamachi,
dstogov,
derickr,
adoy and
kocsismate
as code owners
github-actions
bot
added
Category: Build System
Extension: openssl
Category: Engine
Extension: intl
Extension: com_dotnet
Extension: curl
Extension: date
Extension: dba
Extension: dom
Extension: enchant
Extension: ffi
Extension: ftp
Extension: gd
Extension: json
Extension: ldap
Extension: libxml
Extension: mysqli
labels
github-actions
bot
added
Extension: reflection
Extension: shmop
Extension: simplexml
Extension: snmp
Extension: soap
Extension: sockets
Extension: sodium
Extension: spl
Extension: sqlite3
Extension: standard
Extension: sysvmsg
Extension: sysvsem
Extension: sysvshm
Extension: xml
Extension: zend_test
Extension: zlib
Extension: random
labels
|
ACK for pdo, pdo_dblib, pdo_odbc, odbc, mysqli and sqlite3. BTW, as one of 8.4 RM, I believe this is a okay to include in 8.4 as it is not a userland impacting change. |
Glad to hear it can be included - I have a few other ideas for improvements to the generated arginfo files but to avoid merge conflicts I'm going to wait until after this is (hopefully) merged before sending the next one. |
|
I wonder if a: or would have been preferable. I've currently got a case of an extension that currently doesn't have any global functions, thus requiring me to explicitly pass |
|
@TimWolla Yes, I think your idea makes a lot of sense! |
When a class (or enum) has no methods, rather than using an array that only contains
ZEND_FE_END, useNULLfor the functions. The implementation of class registration for internal classes,do_register_internal_class()in zend_API.c, already skips classes where the functions areNULL. By removing these unneeded arrays, we can reduce the size of the header files, while also removing an unneeded call to zend_register_functions() for each internal class with no extra methods.