Fix GH-17951: Addition of max_memory_limit INI #18011
Conversation
|
Looks good in general though. 👍 |
|
@frederikpyt Feel free to ping me again ~2 weeks after you've sent the e-mail to the internals mailing list. If there are no objections, this may be merged. |
|
This feature looks interesting, but I don't see the email to the internals mailing list? |
|
Looks like it was never sent, unfortunately. @frederikpyt Are you still planning on sending an e-mail? It doesn't need to be long, but it would be a shame if your work went to waste. |
| if (PG(max_memory_limit) != -1) { | ||
| if (value == -1) { | ||
| zend_error( | ||
| stage == ZEND_INI_STAGE_STARTUP ? E_ERROR : E_WARNING, |
There was a problem hiding this comment.
Looking at this again, I think it would be better to stick to a warning in all cases. Erroring is very harsh, especially on startup, taking down the entire website.
|
One open question is whether exceeding the max_memory_limit should set memory_limit to max_memory_limit, giving it a higher chance not to straight out error. I have sent a short e-mail to internals now (will add the link once it's available in externals.io). |
It appears you forgot, here it is: https://externals.io/message/127108 |
Added a new INI
max_memory_limitwhich acts as a cap on how much you can raisememory_limitusingini_set()during runtime.Perhaps see: #17951