remove sorting

Author: tatevikg1

src/Domain/Subscription/Model/Filter/SubscriberFilter.php

@@ -20,8 +20,6 @@ class SubscriberFilter implements FilterRequestInterface
     private ?bool $isConfirmed;
     private ?bool $isBlacklisted;
     private array $columns;
-    private ?string $sortBy;
-    private ?string $sortDirection;
     private ?string $findColumn;
     private ?string $findValue;
 
@@ -36,8 +34,6 @@ public function __construct(
         ?bool $isConfirmed = null,
         ?bool $isBlacklisted = null,
         array $columns = [],
-        ?string $sortBy = null,
-        ?string $sortDirection = null,
         ?string $findColumn = null,
         ?string $findValue = null,
     ) {
@@ -51,8 +47,6 @@ public function __construct(
         $this->isConfirmed = $isConfirmed;
         $this->isBlacklisted = $isBlacklisted;
         $this->columns = $columns;
-        $this->sortBy = $sortBy;
-        $this->sortDirection = $sortDirection;
         $this->findColumn = $findColumn;
         $this->findValue = $findValue;
     }
@@ -107,16 +101,6 @@ public function getColumns(): array
         return $this->columns;
     }
 
-    public function getSortBy(): ?string
-    {
-        return $this->sortBy;
-    }
-
-    public function getSortDirection(): ?string
-    {
-        return $this->sortDirection;
-    }
-
     public function getFindColumn(): ?string
     {
         return $this->findColumn;

src/Domain/Subscription/Repository/SubscriberAttributeValueRepository.php

@@ -64,15 +64,15 @@ public function getFilteredAfterId(
 
         $countQb = clone $queryBuilder;
         $total = (int) $countQb
-            ->select('COUNT(DISTINCT sav.id)')
+            ->select('COUNT(DISTINCT ad.id)')
             ->getQuery()
             ->getSingleScalarResult();
 
         /** @var list<SubscriberAttributeValue> $items */
         $items = $queryBuilder
-            ->andWhere('sav.id > :lastId')
+            ->andWhere('ad.id > :lastId')
             ->setParameter('lastId', $lastId)
-            ->orderBy('sav.id', 'ASC')
+            ->orderBy('ad.id', 'ASC')
             ->setMaxResults($limit)
             ->getQuery()
             ->getResult();

src/Domain/Subscription/Repository/SubscriberRepository.php

@@ -114,9 +114,6 @@ public function getFilteredAfterId(
             $queryBuilder->andWhere('subscriber.blacklisted = :isBlacklisted')
                 ->setParameter('isBlacklisted', $filter->getIsBlacklisted());
         }
-        if ($filter->getSortBy() !== null) {
-            $queryBuilder->orderBy('subscriber.' . $filter->getSortBy(), $filter->getSortDirection() ?? 'ASC');
-        }
         if ($filter->getFindColumn() && $filter->getFindValue()) {
             $queryBuilder->andWhere('subscriber.' . $filter->getFindColumn() . ' LIKE :search')
                 ->setParameter('search', '%' . $filter->getFindValue() . '%');