ISSUE-338: make login display safe + test config update

Author: tatevikg1

.github/workflows/main.yml

@@ -18,7 +18,7 @@ jobs:
             experimental: true
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Set up PHP ${{ matrix.php-version }}
         uses: shivammathur/setup-php@v2
@@ -79,6 +79,7 @@ jobs:
           cp -fv tests/ci/config.php public_html/lists/config/config.php
           mkdir -p output/screenshots
           mkdir -p build/mails
+          chmod -R 777 output/screenshots build/mails
           ./bin/start-selenium > output/selenium.log 2>&1 &
           sleep 5
           sudo php -S 0.0.0.0:80 -t public_html > /dev/null 2>&1 &

public_html/lists/admin/login.php

@@ -53,15 +53,18 @@ function renderSSO()
         echo '<div style="display: flex; justify-content: space-around; align-items: center;">';
 
         foreach ($GLOBALS['ssoplugin'] as $plugin) {
-            $ssoUrl = $GLOBALS['plugins'][$plugin]->autUrl;
-            $buttonText = 'Login with ' . $GLOBALS['plugins'][$plugin]->settings['display_name']['value'];
+            if (isset($GLOBALS['plugins'][$plugin])) {
+                $pluginInstance = $GLOBALS['plugins'][$plugin];
+                $ssoUrl = $pluginInstance->autUrl;
+                $buttonText = 'Login with ' . getConfig($pluginInstance->name);
 
-            echo '<a href="?' . $ssoUrl . '" 
-            style="display: inline-block; padding: 8px 15px; background-color: #3c3c3c; color: #fff; 
-                   text-decoration: none; border-radius: 5px; font-size: 16px; text-align: center; 
-                   min-width: 120px;">
-            ' .  $buttonText . '
-          </a>';
+                echo '<a href="?' . $ssoUrl . '" 
+                    style="display: inline-block; padding: 8px 15px; background-color: #3c3c3c; color: #fff; 
+                           text-decoration: none; border-radius: 5px; font-size: 16px; text-align: center; 
+                           min-width: 120px;">
+                    ' .  $buttonText . '
+                  </a>';
+            }
         }
 
         echo '</div>';

tests/ci/behat.yml

@@ -54,7 +54,7 @@ default:
           selenium2:
             browser: "firefox"
             wd_host: http://127.0.0.1:4444/wd/hub
-    FailAid\Extension: 
+    FailAid\Extension:
       screenshot:
         directory: ./output/screenshots/
         mode: default
@@ -65,7 +65,7 @@ default:
       image_drivers:
         local:
           screenshot_directory: output/screenshots
-          clear_screenshot_directory: true  
+          clear_screenshot_directory: true
 
 chrome:
   extensions:

tests/features/bootstrap/FeatureContext.php

@@ -1,17 +1,8 @@
 <?php
 
-use Behat\Behat\Context\Context;
 
 use Behat\Mink\Exception\ExpectationException;
 use Behat\MinkExtension\Context\MinkContext;
-#use Behat\MinkExtension\Context\RawMinkContext;
-
-//
-// Require 3rd-party libraries here:
-//
-//   require_once 'PHPUnit/Autoload.php';
-//   require_once 'PHPUnit/Framework/Assert/Functions.php';
-//
 
 /**
  * Features context.
@@ -107,7 +98,7 @@ public function spins($closure, $tries = 10)
                 $closure();
 
                 return;
-            } catch (\Exception $e) {
+            } catch (Exception $e) {
                 if ($i == $tries) {
                     throw $e;
                 }
@@ -179,7 +170,7 @@ public function isLoggedIn($throwsException = false)
     {
         $retVal = $this->token != null;
         if(!$retVal && $throwsException){
-            throw new \Exception('Not logged in yet');
+            throw new Exception('Not logged in yet');
         }
         return $retVal;
     }
@@ -325,4 +316,28 @@ public function iConfirmThePopup()
         $this->getSession()->getDriver()->getWebDriverSession()->accept_alert();
     }
 
+    /**
+     * @Then I must see :text
+     */
+    public function iMustSee($text)
+    {
+        $maxAttempts = 3;
+        $waitTimeMs = 1000;
+        $this->getSession()->wait(5000, "document.readyState === 'complete'");
+
+        for ($attempt = 1; $attempt <= $maxAttempts; $attempt++) {
+            try {
+                $this->assertSession()->pageTextContains($this->fixStepArgument($text));
+                return;
+            } catch (\WebDriver\Exception\StaleElementReference $e) {
+                // Handle Selenium stale element exception, retry
+            } catch (\Behat\Mink\Exception\ResponseTextException $e) {
+                // Handle Mink text assertion failure, retry
+            }
+
+            usleep($waitTimeMs * 1000);
+        }
+
+        throw new Exception(sprintf("Text '%s' not found after %d attempts.", $text, $maxAttempts));
+    }
 }

tests/features/bootstrap/SubscriberContext.php

@@ -3,7 +3,6 @@
 require __DIR__.'/bootstrap.php';
 
 use Behat\Behat\Context\Context;
-use Behat\Gherkin\Node\TableNode;
 use Behat\Gherkin\Node\PyStringNode;
 use Behat\Behat\Hook\Scope\BeforeScenarioScope;
 
@@ -25,10 +24,9 @@ public function beforeScenario(BeforeScenarioScope $scope)
 
     /**
      * @param string $list
-     * @param array $table
-     *
-     * @Given /I have "(.*)" list with the following subscribers:/
+     * @param PyStringNode $stringNode
      * @throws Exception
+     * @Given /I have "(.*)" list with the following subscribers:/
      */
     public function iHaveSubscribersForList($list, PyStringNode $stringNode)
     {

tests/features/getting-started/login.feature

@@ -8,14 +8,14 @@ Feature: Login
         When I fill in "login" with a valid username
         And I fill in "password" with a valid password
         And I press "Continue"
-        Then I should see "Start or continue a campaign"
+        Then I must see "Start or continue a campaign"
 
     Scenario: Login with bad credentials
         Given I am on "/lists/admin/"
         When I fill in "login" with "no-user"
         And I fill in "password" with "no-password"
         And I press "Continue"
-        Then I should see "Incorrect password"
+        Then I must see "Incorrect password"
 
 #    Scenario: Login with only a username
 #        Given I am on "/lists/admin/"

tests/features/getting-started/menu.feature

@@ -7,7 +7,7 @@ Feature: Navigate the app using the menu
 
   Scenario Outline: Use main menu navigation links
     Given I have logged in as an administrator
-    Then I should see "<Pagename>"
+    Then I must see "<Pagename>"
     Examples:
       | Pagename                  |
       | dashboard                 |

tests/features/managing-campaigns/newcampaign.feature

@@ -38,7 +38,7 @@ Feature: Create new campaign
         And I follow "Start a new campaign"
         When I follow "Lists"
         # Try with and without the colon
-        Then I should see "Please select the lists you want to send your campaign to:"
+        Then I must see "Please select the lists you want to send your campaign to:"
         And the "targetlist[all]" checkbox should not be checked
         And the "targetlist[allactive]" checkbox should not be checked