Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on tests #31

Open
nelsonsar opened this issue Sep 15, 2012 · 3 comments
Open

Errors on tests #31

nelsonsar opened this issue Sep 15, 2012 · 3 comments

Comments

@nelsonsar
Copy link
Contributor

When you run Onion test you get, for example:
Undefined property: tests\Onion\Dependency\DependencyResolverTest::$logger

Because some tests use $logger as a static variable but it is not. So we have two approaches:

  1. Use mocked instances of logger;
  2. Creating an instance of logger to each test;
@c9s
Copy link
Member

c9s commented Sep 15, 2012

For that, we can get the logger from Onion\Application::getInstance()->getLogger() for now. ;-)

@nelsonsar
Copy link
Contributor Author

Do you have any flow to pull requests? Because I really wanna contribute with you :-)

@c9s
Copy link
Member

c9s commented Sep 15, 2012

Nop, you simply run unit tests, if tests passes, the pull request should be fine. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants