fix getValues() invalid type

Author: Bleksak

src/Type/Nette/FormContainerValuesDynamicReturnTypeExtension.php

@@ -6,16 +6,18 @@
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Type\ArrayType;
+use PHPStan\Type\BooleanType;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\MixedType;
 use PHPStan\Type\ObjectType;
 use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\Constant\ConstantStringType;
+use PHPStan\Type\ClassStringType;
 use function count;
 
 final class FormContainerValuesDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
-
 	public function getClass(): string
 	{
 		return 'Nette\Forms\Container';
@@ -28,20 +30,43 @@ public function isMethodSupported(MethodReflection $methodReflection): bool
 
 	public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): ?Type
 	{
-		if (count($methodCall->getArgs()) === 0) {
+		$args = $methodCall->getArgs();
+
+		// No argument => default object
+		if (count($args) === 0) {
 			return new ObjectType('Nette\Utils\ArrayHash');
 		}
 
-		$arg = $methodCall->getArgs()[0]->value;
+		$arg = $args[0]->value;
 		$scopedType = $scope->getType($arg);
-		if ($scopedType->isTrue()->yes()) {
-			return new ArrayType(new StringType(), new MixedType());
+
+		if ($scopedType instanceof BooleanType) {
+			if ($scopedType->isTrue()->yes()) {
+				return new ArrayType(new StringType(), new MixedType());
+			}
+
+			// boolean false → object
+			if ($scopedType->isFalse()->yes()) {
+				return new ObjectType('Nette\Utils\ArrayHash');
+			}
 		}
-		if ($scopedType->isFalse()->yes()) {
-			return new ObjectType('Nette\Utils\ArrayHash');
+
+		if ($scopedType instanceof ConstantStringType) {
+			$value = $scopedType->getValue();
+
+			if($scopedType->isClassString()->yes()) {
+				return $scopedType->getClassStringObjectType();
+			}
+
+			if ($value === 'array') {
+				return new ArrayType(new StringType(), new MixedType());
+			}
+
+			if ($value === 'object') {
+				return new ObjectType('Nette\Utils\ArrayHash');
+			}
 		}
 
-		return null;
+		return new ObjectType('Nette\Utils\ArrayHash');
 	}
-
 }