Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/PR creation fails if body exceeds max length #208

Open
mschoettle opened this issue Jan 20, 2025 · 1 comment · May be fixed by #212
Open

Issue/PR creation fails if body exceeds max length #208

mschoettle opened this issue Jan 20, 2025 · 1 comment · May be fixed by #212

Comments

@mschoettle
Copy link
Contributor

When the body length of a merge request is too long, the creation on GitHub fails.

There are two issues with this:

  • the PR is never created
  • the migration continues potential leading to an inconsistent numbering of PRs compared to MRs (if this is needed)

I suggest to detect this issue and stop the process giving the user the ability to shorten the body length.

In our case this happened for a dependency update of node which includes the release notes. It was a change over several versions so there were lots of changes. node includes (or used to?) all commits of a release.

@spruce
Copy link
Member

spruce commented Jan 26, 2025

Sounds good. I just don't have the time to add it currently. I would be willing to accept a PR for this feature.

@mschoettle mschoettle linked a pull request Jan 27, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants