Skip to content

Commit a71f683

Browse files
Merge pull request #2486 from laishere/master
fix #2484, Remove not-empty assert for Cookie.value
2 parents 3547d4f + d92bb6c commit a71f683

File tree

6 files changed

+9
-6
lines changed

6 files changed

+9
-6
lines changed

flutter_inappwebview/example/integration_test/cookie_manager/set_get_delete.dart

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,19 @@ void setGetDelete() {
5555
expect(await cookieManager.removeSessionCookies(), isTrue);
5656
}
5757

58-
await cookieManager.setCookie(url: url, name: "myCookie", value: "myValue");
58+
// Empty cookie-value is allowed according to https://datatracker.ietf.org/doc/html/rfc6265#section-4.1.1
59+
await cookieManager.setCookie(url: url, name: "myCookie", value: "");
5960
List<Cookie> cookies = await cookieManager.getCookies(url: url);
6061
expect(cookies, isNotEmpty);
6162

6263
Cookie? cookie = await cookieManager.getCookie(url: url, name: "myCookie");
64+
expect(cookie?.value.toString(), "");
65+
66+
await cookieManager.setCookie(url: url, name: "myCookie", value: "myValue");
67+
cookies = await cookieManager.getCookies(url: url);
68+
expect(cookies, isNotEmpty);
69+
70+
cookie = await cookieManager.getCookie(url: url, name: "myCookie");
6371
expect(cookie?.value.toString(), "myValue");
6472

6573
expect(

flutter_inappwebview_android/lib/src/cookie_manager.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ class AndroidCookieManager extends PlatformCookieManager
8383
PlatformInAppWebViewController? webViewController}) async {
8484
assert(url.toString().isNotEmpty);
8585
assert(name.isNotEmpty);
86-
assert(value.isNotEmpty);
8786
assert(path.isNotEmpty);
8887

8988
Map<String, dynamic> args = <String, dynamic>{};

flutter_inappwebview_ios/lib/src/cookie_manager.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class IOSCookieManager extends PlatformCookieManager with ChannelController {
8787

8888
assert(url.toString().isNotEmpty);
8989
assert(name.isNotEmpty);
90-
assert(value.isNotEmpty);
9190
assert(path.isNotEmpty);
9291

9392
if (await _shouldUseJavascript()) {

flutter_inappwebview_macos/lib/src/cookie_manager.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ class MacOSCookieManager extends PlatformCookieManager with ChannelController {
8787

8888
assert(url.toString().isNotEmpty);
8989
assert(name.isNotEmpty);
90-
assert(value.isNotEmpty);
9190
assert(path.isNotEmpty);
9291

9392
if (await _shouldUseJavascript()) {

flutter_inappwebview_web/lib/src/cookie_manager.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ class WebPlatformCookieManager extends PlatformCookieManager
8989

9090
assert(url.toString().isNotEmpty);
9191
assert(name.isNotEmpty);
92-
assert(value.isNotEmpty);
9392
assert(path.isNotEmpty);
9493

9594
await _setCookieWithJavaScript(

flutter_inappwebview_windows/lib/src/cookie_manager.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ class WindowsCookieManager extends PlatformCookieManager
9595
PlatformInAppWebViewController? webViewController}) async {
9696
assert(url.toString().isNotEmpty);
9797
assert(name.isNotEmpty);
98-
assert(value.isNotEmpty);
9998
assert(path.isNotEmpty);
10099

101100
Map<String, dynamic> args = <String, dynamic>{};

0 commit comments

Comments
 (0)