Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight does not work with divs #84

Open
tarr11 opened this issue Jan 18, 2013 · 5 comments
Open

Highlight does not work with divs #84

tarr11 opened this issue Jan 18, 2013 · 5 comments

Comments

@tarr11
Copy link

tarr11 commented Jan 18, 2013

I'm using guiders with the highlight option. It appears to highlight input elements, but not divs. I've verified that it is applying the guiders_highlight class to the element. But it appears to not actually highlight anything.

Is there any way to get highlight to work with divs?

@pickhardt
Copy link
Owner

Highlight works by adding a class "guiders_highlight" to the div, giving it
a higher z-index.

Have you tried a few things:

  • ensuring your css file has a high z index for guiders_highlight? (It's
    set to 101 by default)
  • check the position attribute of your div

If there is a bug, I suspect it is something along the lines of "the div is
getting the guiders_highlight class, but the elements inside the div aren't
benefitting from the higher z-index because the position attribute was left
empty"

Jeff Pickhardt
[email protected]

On Thu, Jan 17, 2013 at 6:48 PM, Douglas Tarr [email protected]:

I'm using guiders with the highlight option. It appears to highlight input
elements, but not divs. I've verified that it is applying the
guiders_highlight class to the element. But it appears to not actually
highlight anything.

Is there any way to get highlight to work with divs?


Reply to this email directly or view it on GitHubhttps://github.com//issues/84.

@pickhardt
Copy link
Owner

I agree that there is a bug. I don't know exactly how to solve it, though. I've replicated it: perhaps your div doesn't have a background color? I've found that added a bg color helped me, when I replicated it.

@djhopper01
Copy link

Thanks @pickhardt. I ran into a similar issue when the div did not have a background color. Adding a background color makes the div look much better.

@h0ru5
Copy link

h0ru5 commented Aug 4, 2013

Also stumbled across that issue, setting a white background works fine for my case.

For a cleaner solution, you could lay a white highlighting-backdrop under the element to highlight, so that z-order(backdrop) < z-order(white background) < z-order(highlighted element), Tricky thing is to put the white background into the same position and size as the element.

Bootstrap-tour does this, see https://github.com/sorich87/bootstrap-tour for an example.

@jdan
Copy link

jdan commented Aug 12, 2014

Sometimes it's just a z-index annoyance and changing the background color isn't enough. Make sure to set your highlighted element's position to "relative"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants