Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laser_acceleration_PICMI.py example not consistent with PICMI standard? #68

Open
RTSandberg opened this issue Mar 14, 2022 · 1 comment
Labels
bug Something isn't working Documentation Add or update documentation and comments

Comments

@RTSandberg
Copy link
Contributor

The lower and upper r boundary conditions in RZ geometry are specified as None and 'reflective' but the standard only lists 'dirichlet', 'Neumann', and 'open' as possibilities. Should these be changed in the example to 'dirichlet' and something else? Or should the standard be expanded to allow 'reflective' and None?
Could warnings be issued for PICMI options that aren't in the standard?

@dpgrote
Copy link
Member

dpgrote commented Mar 14, 2022

Thanks for pointing this out. For the lower boundary, PICMI should be updated to include the option None (meaning the natural boundary condition at r=0).

For the upper boundary, I see that FBPIC supports the reflective option (and WarpX does not). @RemiLehe what is the reflective BC in FBPIC? Is it the same as Dirichlet?

@ax3l ax3l added bug Something isn't working Documentation Add or update documentation and comments labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Documentation Add or update documentation and comments
Projects
None yet
Development

No branches or pull requests

3 participants