Merge pull request #199 from robindirksen1/patch-2

Error with dirty attributes (Fix #198)

Author: stephangroen

src/Picqer/Financials/Moneybird/Model.php

@@ -214,7 +214,7 @@ public function getDirtyValues()
      */
     public function isAttributeDirty($attributeName)
     {
-        if (in_array($attributeName, $this->attribute_changes)) {
+        if (array_key_exists($attributeName, $this->attribute_changes)) {
             return true;
         }
 

tests/PicqerTest/Financials/Moneybird/ModelTest.php

@@ -114,6 +114,9 @@ public function testRegisterAttributesAsDirty()
         $this->assertEquals('id', $invoice->getDirty()[0]);
         $this->assertEquals('invoice_date', $invoice->getDirty()[1]);
         $this->assertEquals(2, count($invoice->getDirty()));
+        $this->assertTrue($invoice->isAttributeDirty('id'));
+        $this->assertTrue($invoice->isAttributeDirty('invoice_date'));
+        $this->assertFalse($invoice->isAttributeDirty('unknown_key'));
 
         //check if the getDirtyValues from is null (new object)
         $this->assertEquals(null, $invoice->getDirtyValues()['invoice_date']['from']);