Fix linting errors.

Author: Gadgetoid

examples/alert/alert.py

@@ -55,10 +55,8 @@
 def make_starfield():
     # populates the starfield with random stars and ships
     global stars, pmc, ship
-    stars = []
     pmc = (random.randint(0, WIDTH - 50), random.randint(HEIGHT - 160, HEIGHT - 120))
-    for i in range(90):
-        stars.append((random.randint(8, WIDTH - 8), random.randint(HEIGHT - 180, HEIGHT - 100)))
+    stars = [(random.randint(8, WIDTH - 8), random.randint(HEIGHT - 180, HEIGHT - 100)) for _ in range(90)]
     ship = (random.randint(0, WIDTH - 50), random.randint(HEIGHT - 160, HEIGHT - 120), random.choice(SHIPS))
 
 
@@ -88,7 +86,7 @@ def full_refresh():
     frequency = 440
     # draw the elements that we don't need to redraw every time
     # we're drawing them twice, so they end up in both buffers
-    for i in range(2):
+    for _ in range(2):
         # clear the screen
         graphics.set_pen(BLACK)
         graphics.clear()
@@ -140,14 +138,12 @@ def rectangle(x, y, w, h, cx=0, cy=0):
 graph_hue = 0.0
 pulse = 0.0
 pulse_direction = PULSE_SPEED
-graph_data = []
 frequency = 440
 
 # setup
 current_mode = MODES[0]
-# populate the graph data list with 12 random values between 1 and 100
-for i in range(12):
-    graph_data.append(random.randint(1, 100))
+# create the graph data list with 12 random values between 1 and 100
+graph_data = [random.randint(1, 100) for _ in range(12)]
 vector.set_antialiasing(ANTIALIAS_X16)
 full_refresh()
 

examples/bouncing_logo/bouncing_logo.py

@@ -180,8 +180,8 @@ def draw_background():
     """Draws a gradient background"""
     t = time.ticks_ms() / 1000.0
     grid_size = 40
-    for y in range(0, HEIGHT // grid_size):
-        for x in range(0, WIDTH // grid_size):
+    for y in range(HEIGHT // grid_size):
+        for x in range(WIDTH // grid_size):
             h = x + y + int(t * 5)
             h = h / 50.0
 

examples/co2/co2.py

@@ -115,7 +115,7 @@ def line_polygon(top, bottom, min, max, value):
 
         # if lists are empty, populate the list with the current readings
         if len(co2_readings) == 0:
-            for i in range(MAX_READINGS):
+            for _ in range(MAX_READINGS):
                 co2_readings.append(co2)
                 temperature_readings.append(temperature)
                 humidity_readings.append(humidity)

examples/floppy_birb/floppy_birb.py

@@ -42,6 +42,7 @@
 # The pipe cap will hide any overshoot.
 SPRITE_PIPE_HEIGHT = 10
 
+# Twice to fill the front/back buffers
 for _ in range(2):
     # Pipes and goals
     display.load_sprite("/floppy_birb/pipe.png", SPRITE_PIPE, (0, 0, 20, SPRITE_PIPE_HEIGHT))
@@ -103,7 +104,7 @@
 game_state = GAME_GET_READY
 t_start = 0
 
-
+# Twice to fill the front/back buffers
 for _ in range(2):
     # Scroll position two for fixed top/bottom
     display.set_scroll_group_for_lines(2, 0, GAME_TOP - 20)
@@ -168,8 +169,8 @@ def draw_score():
 
 
 def prep_game():
-    # Prep the backdrop
-    for display_index in range(2):
+    # Prep the backdrop, twice to fill the front/back buffers
+    for _ in range(2):
         display.set_pen(GROUND)
         display.clear()
         display.set_pen(BLACK)
@@ -218,7 +219,8 @@ def reset_game():
 
     birb.reset()
 
-    for display_index in range(2):
+    # Twice to fill front/back buffer
+    for _ in range(2):
         draw_score()
         display.update()
 
@@ -265,8 +267,9 @@ def test(self, x, y, w, h):
                 action(**args)
 
     def debug(self, offset_x):
+        # Twice to fill the front/back buffers
         for _ in range(2):
-            for zone, action in self.zones:
+            for zone, _ in self.zones:
                 zx, zy, zw, zh = zone
                 display.set_pen(display.create_pen(255, 0, 0))
                 display.rectangle(zx + offset_x, zy, zw, zh)
@@ -358,7 +361,7 @@ def main_game_running(t_current):
         if hq_xoffset < GAME_WIDTH and hq_xoffset > -(hq * 32) - 32:
             spritelist.add(spr, hq_xoffset + (hq * 32), hq_yoffset)
 
-    for pipe in range(0, SLICES + 1):
+    for pipe in range(SLICES + 1):
         try:
             gap = PIPE_GAPS[level_offset + pipe]
             gap_width = GAP_WIDTHS[level_offset + pipe]

examples/magic_mirror/magic_mirror.py

@@ -122,10 +122,9 @@ def connect_to_wifi():
         if wlan.isconnected():
             print("Connected to WiFi successfully.")
             return True
-        else:
-            print("Failed to connect to WiFi. Retrying...")
-            retries += 1
-            time.sleep(2)  # Wait for 2 seconds before retrying
+        print("Failed to connect to WiFi. Retrying...")
+        retries += 1
+        time.sleep(2)  # Wait for 2 seconds before retrying
 
     print("Failed to connect to WiFi after maximum retries.")
     return False
@@ -137,14 +136,13 @@ def get_data():
     if connect_to_wifi() is False:
         wifi_problem = True
         return
-    else:
-        wifi_problem = False
+    wifi_problem = False
 
     try:
         print("Setting time from NTP")
         ntptime.settime()
         print(f"Time set (UTC): {rtc.datetime()}")
-    except Exception as e:
+    except OSError as e:
         print(e)
 
     get_weather_data()
@@ -169,7 +167,7 @@ def get_weather_data():
         weathercode = current["weathercode"]
         date, now = current["time"].split("T")
         r.close()
-    except Exception as e:
+    except OSError as e:
         print(e)
 
 
@@ -186,13 +184,13 @@ def get_quote_data():
         quote = j[0]["content"]
         author = j[0]["author"]
         r.close()
-    except Exception as e:
+    except OSError as e:
         print(e)
 
 
 def calculate_bearing(d):
     # calculates a compass direction from the wind direction in degrees
-    dirs = ['N', 'NNE', 'NE', 'ENE', 'E', 'ESE', 'SE', 'SSE', 'S', 'SSW', 'SW', 'WSW', 'W', 'WNW', 'NW', 'NNW']
+    dirs = ["N", "NNE", "NE", "ENE", "E", "ESE", "SE", "SSE", "S", "SSW", "SW", "WSW", "W", "WNW", "NW", "NNW"]
     ix = round(d / (360. / len(dirs)))
     return dirs[ix % len(dirs)]
 

examples/magic_mirror/magic_mirror_home_assistant.py

@@ -86,16 +86,11 @@
 temperature = None
 wifi_problem = False
 
-buildings = []
 BUILDING_COUNT = 20
-for b in range(WIDTH // BUILDING_COUNT):
-    buildings.append(random.randint(0, HEIGHT // 6))
+buildings = [random.randint(0, HEIGHT // 6) for _ in range(WIDTH // BUILDING_COUNT)]
 
-
-stars = []
 STAR_COUNT = 50
-for s in range(STAR_COUNT):
-    stars.append((random.randint(0, WIDTH), random.randint(0, HEIGHT)))
+stars = [(random.randint(0, WIDTH), random.randint(0, HEIGHT)) for _ in range(STAR_COUNT)]
 
 
 # Connect to wifi
@@ -132,10 +127,9 @@ def connect_to_wifi():
         if wlan.isconnected():
             print("Connected to WiFi successfully.")
             return True
-        else:
-            print("Failed to connect to WiFi. Retrying...")
-            retries += 1
-            time.sleep(2)  # Wait for 2 seconds before retrying
+        print("Failed to connect to WiFi. Retrying...")
+        retries += 1
+        time.sleep(2)  # Wait for 2 seconds before retrying
 
     print("Failed to connect to WiFi after maximum retries.")
     return False
@@ -147,14 +141,13 @@ def get_data():
     if connect_to_wifi() is False:
         wifi_problem = True
         return
-    else:
-        wifi_problem = False
+    wifi_problem = False
 
     try:
         print("Setting time from NTP")
         ntptime.settime()
         print(f"Time set (UTC): {rtc.datetime()}")
-    except Exception as e:
+    except OSError as e:
         print(e)
 
     get_home_assistant_data()
@@ -177,7 +170,7 @@ def get_home_assistant_data():
         print(j)
         sunset_date, sunset_time = j["state"].split("T")
         r.close()
-    except Exception as e:
+    except OSError as e:
         print(e)
 
     print("Requesting Home Assistant data")
@@ -188,7 +181,7 @@ def get_home_assistant_data():
         print(j)
         sunrise_date, sunrise_time = j["state"].split("T")
         r.close()
-    except Exception as e:
+    except OSError as e:
         print(e)
 
 
@@ -238,8 +231,8 @@ def redraw_display_if_reqd():
 
         if sunrise_date and sunset_date is not None:
             # Convert the sunrise, sunset and RTC times to a common 'minutes since midnight' format, so we can compare:
-            sunrise_split = sunrise_time.split(':')
-            sunset_split = sunset_time.split(':')
+            sunrise_split = sunrise_time.split(":")
+            sunset_split = sunset_time.split(":")
             sunrise_minutes = (int(sunrise_split[0]) + UTC_OFFSET) * 60 + int(sunrise_split[1])
             sunset_minutes = (int(sunset_split[0]) + UTC_OFFSET) * 60 + int(sunset_split[1])
             rtc_minutes = (rtc.datetime()[4] + UTC_OFFSET) * 60 + rtc.datetime()[5]

examples/main.py

@@ -132,6 +132,7 @@ def menu() -> str:
     omg_toasters = False
     last_button = time.ticks_ms() / 1000.0
 
+    # Twice to fill the front/back buffers
     for _ in range(2):
         display.set_scroll_group_for_lines(1, HEIGHT - 20, HEIGHT)
         display.set_scroll_group_offset(1, 0, 0, wrap_x=WIDTH)
@@ -198,7 +199,7 @@ def menu() -> str:
 
         scroll_position += (target_scroll_position - scroll_position) / 5
 
-        for y in range(0, int(HEIGHT / 2)):
+        for y in range(int(HEIGHT / 2)):
             bg = background_pen
             sl = scanline_pen
             if y <= 10:

examples/screenmodes.py

@@ -54,7 +54,8 @@
 modechange = 0
 
 while True:
-    for p in range(2):
+    # Twice to fill the front/back buffers
+    for _ in range(2):
         if modeChange == 0:
             display.set_pen(0)
             display.clear()
@@ -92,7 +93,8 @@
             while display.is_button_x_pressed():
                 m = 0
 
-        for p in range(2):
+        # Twice to fill the front/back buffers
+        for _ in range(2):
             display.set_pen(DARKGREY)
             display.rectangle(14, 22, 137, numModes * 10 + 14)
             for f in range(numModes):

examples/scrollgroups.py

@@ -269,7 +269,8 @@ def drawShip(s):
 
 
 while True:
-    for p in range(2):
+    # Twice to fill the front/back buffers
+    for _ in range(2):
         display.set_scroll_group_for_lines(1, 0, 30)
         display.set_scroll_group_for_lines(2, 30, 55)
         display.set_scroll_group_for_lines(3, 55, 75)

examples/seafax.py

@@ -58,7 +58,7 @@ def network_connect(ssid, psk):
         if wlan.status() < 0 or wlan.status() >= 3:
             break
         max_wait -= 1
-        print('waiting for connection...')
+        print("waiting for connection...")
         time.sleep(1)
 
     # Handle connection error.
@@ -151,8 +151,7 @@ def parse_xml_stream(s, accept_tags, group_by, max_items=7):
 def get_rss():
     try:
         stream = urequest.urlopen(URL)
-        output = list(parse_xml_stream(stream, [b"title", b"description", b"guid", b"pubDate"], b"item"))
-        return output
+        return list(parse_xml_stream(stream, [b"title", b"description", b"guid", b"pubDate"], b"item"))
 
     except OSError as e:
         print(e)

examples/sneks_and_ladders/sneks_and_ladders.py

@@ -146,7 +146,7 @@ def draw_level():
     fire_tilemap = [0, 2, 1, 4, 3]
 
     # Repeat the frame sequence, adding one to each frame and wrapping on FIRE_FRAMES
-    for x in range(FIRE_FRAMES + 4):
+    for _ in range(FIRE_FRAMES + 4):
         next_step = [(n + 1) % FIRE_FRAMES for n in fire_tilemap[-FIRE_FRAMES:]]
         fire_tilemap += next_step
 

examples/starfield.py

@@ -16,25 +16,21 @@
 BLACK = graphics.create_pen(0, 0, 0)
 WHITE = graphics.create_pen(255, 255, 255)
 
-stars = []
-
 
 def new_star():
     # Create a new star, with initial x, y, and size
     # Initial x will fall between -WIDTH / 2 and +WIDTH / 2 and y between -HEIGHT/2 and +HEIGHT/2
     # These are relative values for now, treating (0, 0) as the centre of the screen.
-    star = [random.randint(0, WIDTH) - WIDTH // 2, random.randint(0, HEIGHT) - HEIGHT // 2, 0.5]
-    return star
+    return [random.randint(0, WIDTH) - WIDTH // 2, random.randint(0, HEIGHT) - HEIGHT // 2, 0.5]
 
 
-for i in range(0, NUMBER_OF_STARS):
-    stars.append(new_star())
+stars = [new_star() for _ in range(NUMBER_OF_STARS)]
 
 while True:
     graphics.set_pen(BLACK)
     graphics.clear()
     graphics.set_pen(WHITE)
-    for i in range(0, NUMBER_OF_STARS):
+    for i in range(NUMBER_OF_STARS):
         # Load a star from the stars list
         s = stars[i]
 

examples/starfield_rainbow.py

@@ -18,24 +18,20 @@
 BLACK = graphics.create_pen(0, 0, 0)
 WHITE = graphics.create_pen(255, 255, 255)
 
-stars = []
-
 
 def new_star():
     # Create a new star, with initial x, y, size and hue
     # Initial x will fall between -WIDTH / 2 and +WIDTH / 2 and y between -HEIGHT/2 and +HEIGHT/2
     # These are relative values for now, treating (0, 0) as the centre of the screen.
-    star = [random.randint(0, WIDTH) - WIDTH // 2, random.randint(0, HEIGHT) - HEIGHT // 2, 1.0, random.random()]
-    return star
+    return [random.randint(0, WIDTH) - WIDTH // 2, random.randint(0, HEIGHT) - HEIGHT // 2, 1.0, random.random()]
 
 
-for i in range(0, NUMBER_OF_STARS):
-    stars.append(new_star())
+stars = [new_star() for _ in range(NUMBER_OF_STARS)]
 
 while True:
     graphics.set_pen(BLACK)
     graphics.clear()
-    for i in range(0, NUMBER_OF_STARS):
+    for i in range(NUMBER_OF_STARS):
         # Load a star from the stars list
         s = stars[i]
 

examples/vector_clock_smooth.py

@@ -130,7 +130,7 @@
     clip_max_y = max(second_hand_bounds[1] + second_hand_bounds[3], minute_hand_bounds[1] + minute_hand_bounds[3], hour_hand_bounds[1] + hour_hand_bounds[3]) + 5
 
     # Remember this clipping window for 2 frames time
-    last_clip.append((clip_x, clip_y, clip_max_x, clip_max_y),)
+    last_clip.append((clip_x, clip_y, clip_max_x, clip_max_y))
 
     # Expand to also cover the clipping window from 2 frames ago
     clip_x = min(clip_x, last_clip[0][0])

lib/boot.py

@@ -1,3 +1,3 @@
 import cppmem
 # Switch C++ memory allocations to use MicroPython's heap
-cppmem.set_mode(cppmem.MICROPYTHON)
+cppmem.set_mode(cppmem.MICROPYTHON)