CMakeLists for utils, platform, and rtos targets#103
Conversation
|
I'll review this this weekend. What I'll likely do is merge into @Ralim I will handle this PR =) |
Cool, no rush. I mostly opened this so we can avoid redoing the same work separately
Makes sense, and is the target branch for this PR anyway :)
Up to you, I don't mind working via PR, but it might be easier with push access to |
shymega
left a comment
shymega
left a comment
There was a problem hiding this comment.
Overall, I think we can merge, but I just wanted to delve into these lines.
Thanks.
|
Sorry for the delay in review. I've got round to it now. |
|
@Ralim I've requested your review here - would like to get your clearance on this PR. |
|
@shymega |
|
@Ralim Thanks, will do. |
|
@nicka101 I've rebased your branch, and applied the fixes. I'm keen to get this into my branch as soon as possible, and I'm especially grateful for your work here. Would you agree that squashing the commits in this PR would be a good idea? Cheers. |
|
By all means, do whatever you see fit to manage the branch. |
Main work by @nicka101. Also, by @shymega: - Add another `target_link_libraries` to util_sha256 This links to CMSIS and HAL libs. - Fixup Dockerfile for GCC ARM download, and tidy - Had to run `dos2unix` on some files. - Remove `*.cmake` from .gitignore This allows us to keep future CMake modules, for example, Corrosion. - Update devcontainer.json name - Move `.devcontainer/devcontainer.json` to root of repo Signed-off-by: Dom Rodriguez <[email protected]>
|
@nicka101 Alright. I'll merge this now, so we can progress with the CMake conversion. Many thanks for your contribution! Anything else, feel free to open more PRs - we could sure use it! |
3 participants
utils,platformandrtosfolders.platform_cmsis, andutil_crash_catcher)In its current state, I don't attempt to cover the options/defines from the Makefiles (primarily just the targets themselves and their includes/links), and
platform_cmsisseems to be the biggest blocker to compilation, representing the vast majority of the errors. The fact it doesn't build successfully is also the primary reason this PR is marked draft, though neither does the HEAD of the cmake branch, so feel free to merge this if you want