Skip to content

Commit 1010f10

Browse files
Bump dependency: golang.org/x/[email protected] (#111)
Dependabot opened a PR for bumping the `golang.org/x/net` dependency from 0.33.0 -> 0.38.0. However, in order to make that jump, we'd need to bump the Go version our module supports from go 1.21 -> go 1.24. For consumers, this would be a breaking change and they'd need to upgrade their version of Go to use the SDK. At the moment, I don't think is necessary for this release. For now I've updated to `golang.org/x/net v0.35.0` which is the last version which supports < `go v1.23`: - https://cs.opensource.google/go/x/net/+/refs/tags/v0.35.0:go.mod - https://cs.opensource.google/go/x/net/+/refs/tags/v0.36.0:go.mod Bump `golang.org/x/net` -> `v0.35.0`. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [X] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) CI
1 parent 4a8a742 commit 1010f10

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ require (
1616
github.com/apapsch/go-jsonmerge/v2 v2.0.0 // indirect
1717
github.com/davecgh/go-spew v1.1.1 // indirect
1818
github.com/pmezard/go-difflib v1.0.0 // indirect
19-
golang.org/x/net v0.33.0 // indirect
19+
golang.org/x/net v0.35.0 // indirect
2020
golang.org/x/sys v0.30.0 // indirect
2121
golang.org/x/text v0.22.0 // indirect
2222
google.golang.org/genproto/googleapis/rpc v0.0.0-20240528184218-531527333157 // indirect

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+
1919
github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI=
2020
github.com/stretchr/testify v1.8.4 h1:CcVxjf3Q8PM0mHUKJCdn+eZZtm5yQwehR5yeSVQQcUk=
2121
github.com/stretchr/testify v1.8.4/go.mod h1:sz/lmYIOXD/1dqDmKjjqLyZ2RngseejIcXlSw2iwfAo=
22-
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
23-
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
22+
golang.org/x/net v0.35.0 h1:T5GQRQb2y08kTAByq9L4/bz8cipCdA8FbRTXewonqY8=
23+
golang.org/x/net v0.35.0/go.mod h1:EglIi67kWsHKlRzzVMUD93VMSWGFOMSZgxFjparz1Qk=
2424
golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
2525
golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
2626
golang.org/x/text v0.22.0 h1:bofq7m3/HAFvbF51jz3Q9wLg3jkvSPuiZu/pD1XwgtM=

pinecone/index_connection_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -474,14 +474,12 @@ func (ts *IntegrationTests) TestListNamespaces() {
474474
require.Equal(ts.T(), limit, uint32(len(namespaces.Namespaces)))
475475

476476
// List remaining
477-
remainingLength := uint32(len(ts.namespaces) - int(limit))
478477
namespaces, err = ts.idxConn.ListNamespaces(ctx, &ListNamespacesParams{
479478
PaginationToken: &namespaces.Pagination.Next,
480-
Limit: &remainingLength,
481479
})
482480
require.NoError(ts.T(), err)
483481
require.NotNil(ts.T(), namespaces, "ListNamespaces response should not be nil")
484-
require.Equal(ts.T(), limit, uint32(len(namespaces.Namespaces)), "ListNamespaces should return the remaining namespaces")
482+
require.Greater(ts.T(), len(namespaces.Namespaces), 0, "ListNamespaces should return the second page of results")
485483
}
486484

487485
func (ts *IntegrationTests) TestDeleteNamespace() {

0 commit comments

Comments
 (0)