pkg/domain: remove duplicate EtcdClient() method

Co-authored-by: lance6716 <[email protected]>

Author: Copilot

pkg/ddl/schema_test.go

@@ -300,7 +300,7 @@ func TestSchemaWaitJob(t *testing.T) {
 	require.True(t, domain.DDL().OwnerManager().IsOwner())
 
 	d2, de2 := ddl.NewDDL(context.Background(),
-		ddl.WithEtcdClient(domain.EtcdClient()),
+		ddl.WithEtcdClient(domain.GetEtcdClient()),
 		ddl.WithStore(store),
 		ddl.WithInfoCache(domain.InfoCache()),
 		ddl.WithLease(testLease),

pkg/domain/domain.go

@@ -241,11 +241,6 @@ func (do *Domain) InfoCache() *infoschema.InfoCache {
 	return do.infoCache
 }
 
-// EtcdClient export for test.
-func (do *Domain) EtcdClient() *clientv3.Client {
-	return do.etcdClient
-}
-
 // UnprefixedEtcdCli export for test.
 func (do *Domain) UnprefixedEtcdCli() *clientv3.Client {
 	return do.unprefixedEtcdCli

pkg/session/bootstrap_test.go

@@ -2641,7 +2641,7 @@ func checkETCDNameSpace(t *testing.T, dom *domain.Domain, isHasPrefix bool) {
 	}
 
 	// Put key value into etcd.
-	_, err := dom.EtcdClient().Put(context.Background(), testKeyWithoutPrefix, testVal)
+	_, err := dom.GetEtcdClient().Put(context.Background(), testKeyWithoutPrefix, testVal)
 	require.NoError(t, err)
 
 	// Use expectTestKey to get the key from etcd.

pkg/session/sync_upgrade.go

@@ -63,7 +63,7 @@ func SyncUpgradeState(s sessionctx.Context, timeout time.Duration) error {
 
 		var op owner.OpType
 		childCtx, cancel := context.WithTimeout(ctx, 3*time.Second)
-		op, err = owner.GetOwnerOpValue(childCtx, dom.EtcdClient(), ddl.DDLOwnerKey)
+		op, err = owner.GetOwnerOpValue(childCtx, dom.GetEtcdClient(), ddl.DDLOwnerKey)
 		cancel()
 		if err == nil && op.IsSyncedUpgradingState() {
 			break

tests/realtikvtest/brietest/pitr_test.go

@@ -135,7 +135,7 @@ type LogBackupKit struct {
 
 func NewLogBackupKit(t *testing.T) *LogBackupKit {
 	tk := initTestKit(t)
-	metaCli := streamhelper.NewMetaDataClient(domain.GetDomain(tk.Session()).EtcdClient())
+	metaCli := streamhelper.NewMetaDataClient(domain.GetDomain(tk.Session()).GetEtcdClient())
 	begin := time.Now()
 	// So the cases can finish faster...
 	tk.MustExec("set config tikv `log-backup.max-flush-interval` = '30s';")