Skip to content

distributeDDLOwnerLock doesn't keyspace as prefix on nextgen #61587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
D3Hunter opened this issue Jun 9, 2025 · 0 comments · Fixed by #61588
Closed

distributeDDLOwnerLock doesn't keyspace as prefix on nextgen #61587

D3Hunter opened this issue Jun 9, 2025 · 0 comments · Fixed by #61588
Labels
component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 9, 2025

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

during upgrade, ddl use distributeDDLOwnerLock to let some node to be owner, this lock doesn't consider keyspace right now

tidb/pkg/session/bootstrap.go

Lines 1569 to 1580 in fa3c79b

etcdCli, err := storepkg.NewEtcdCli(store)
if err != nil {
return nil, errors.Trace(err)
}
if etcdCli == nil {
// Special handling for test.
logutil.BgLogger().Warn("skip acquire ddl owner lock for uni-store")
return func() {
// do nothing
}, nil
}
releaseFn, err := owner.AcquireDistributedLock(context.Background(), etcdCli, bootstrapOwnerKey, 10)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

master
@D3Hunter D3Hunter added type/bug The issue is confirmed as a bug. severity/minor component/ddl This issue is related to DDL of TiDB. labels Jun 9, 2025
@D3Hunter D3Hunter mentioned this issue Jun 9, 2025
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 10, 2025
@D3Hunter
ddl: add keyspace for distributeDDLOwnerLock (#61588)
51f0587 
close #61587
AilinKid pushed a commit to AilinKid/tidb that referenced this issue Jun 10, 2025
@D3Hunter @AilinKid
ddl: add keyspace for distributeDDLOwnerLock (pingcap#61588)
00cb279 
close pingcap#61587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ddl This issue is related to DDL of TiDB. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl: add keyspace for distributeDDLOwnerLock D3Hunter/tidb
1 participant
@D3Hunter