Skip to content

Latest commit

 

History

History
166 lines (102 loc) · 10 KB

CONTRIBUTING.md

File metadata and controls

166 lines (102 loc) · 10 KB

Contributing to PipeCD

If you're interested in contributing to PipeCD, this document will provide clear instructions on how to get involved.

Note: Don't bother reading policies and flows, just want to manipulate the code? Jump to the Development section.

The Open Source Guides website offers a collection of resources for individuals, communities, and companies who want to learn how to run and contribute to an open source project. Both contributors and newcomers to open source will find the following guides especially helpful:

Code of Conduct

PipeCD follows the CNCF Code of Conduct. Please read it to understand which actions are acceptable and which are not.

Get Involved

There are various ways to contribute to PipeCD, and many of them don't involve writing code. Here are a few ideas to help you get started:

  • Start by using PipeCD. Follow the Quickstart guide. Does everything work as expected? If not, we're always looking for improvements. Let us know by opening an issue.
  • Browse through the open issues. Provide workarounds, ask for clarification, or suggest labels.
  • If you find an issue you'd like to fix, open a pull request. Issues labeled as Good first issue are a good starting point.
  • Read the PipeCD docs. If you come across anything that is confusing or can be improved, click "Edit this page" on the right side of most docs to propose changes through the GitHub interface.
  • Participate in Discussions and share your ideas.

Contributions are highly welcome. If you need help planning your contribution, please reach out to us on Twitter at @pipecd_dev and let us know you're seeking assistance.

Join our Slack Channel

We have a #pipecd channel on CNCF Slack for discussions related to PipeCD development. You can also provide valuable help by assisting other users in the channel.

Our Development Process

PipeCD uses GitHub as its source of truth. The core team will be working directly there. All changes will be public from the beginning.

All pull requests undergo checks by the continuous integration system, GitHub Actions. These checks include unit tests, lint tests, and more.

Branch Organization

PipeCD has one primary branch master.

Issues

When opening a new issue, please make sure to fill out the issue template. This step is crucial! Neglecting to do so may result in your issue not being promptly addressed. If this happens, feel free to open a new issue once you have gathered all the necessary information.

Bugs

We use GitHub Issues for our public bug reports. If you encounter a problem, take a look around to see if someone has already reported it. If you believe you have found a new, unreported bug, you can submit a bug report.

  • One issue, one bug: Please report a single bug per issue.
  • Provide reproduction steps: List all the steps necessary to reproduce the issue. The person reading your bug report should be able to follow these steps with minimal effort.

If you are only fixing a bug, you can submit a pull request right away, but we still recommend filing an issue to describe what you are fixing. This is helpful in case we do not accept that specific fix but still want to track the issue.

Security Bugs

If you discover security-related bugs that may compromise the security of current users, please send a direct message to our maintainers on Slack or Twitter instead of opening a public issue.

You can find our DM contacts via MAINTAINERS.md.

Enhancement requests

If you would like to request an enhancement to existing features, you can file an issue with the enhancement request template.

Feature requests

If you would like to request an entirely new feature, you can file an issue with the feature request.

Claiming issues

We maintain a list of good first issues to help you get started with the PipeCD codebase and familiarize yourself with our contribution process. It's an excellent place to begin.

If you want to work on any of these issues, simply leave a message saying "I'd like to work on this," and we will assign the issue to you and update its status as "claimed." We expect you to submit a pull request within seven days so that we can assign the issue to someone else if you are unavailable.

Development

PipeCD consists of several components and docs:

  • cmd/pipecd: A centralized component that manages deployment data and provides a gRPC API for connecting pipeds, as well as web functionalities such as authentication. README.md
  • cmd/piped: piped is an agent component that runs in your cluster. README.md
  • cmd/pipectl: The command-line tool for PipeCD. README.md
  • cmd/launcher: The command executor that enables the remote upgrade feature of the piped agent. README.md
  • web: The web application provided by the control plane. README.md
  • docs: Documentation and references. README.md

You can find detailed development information in the README file of each directory.

Note: While working with the PipeCD codebase, you may refer to Makefile for useful commands.

Online one-click setup for contributing

We are preparing Gitpod and Codespace to facilitate the setup process for contributing.

Pull Requests

So you've decided to contribute code back to the upstream by opening a pull request. You've put in a significant amount of time, and we appreciate your effort. We will do our best to work with you and review the pull request.

Are you working on your first Pull Request? You can learn how to do it from this free video series:

How to Contribute to an Open Source Project on GitHub

When submitting a pull request, please ensure the following:

  • Keep your PR small. Small pull requests (~300 lines of diff) are much easier to review and are more likely to get merged. Make sure the PR addresses only one thing. If not, please split it.
  • Use descriptive titles. It is recommended to follow the commit message style.
  • DCO. If you haven't signed off already, check the Contributor License Agreement.

All pull requests should be opened against the master branch.

We have various integration systems that run automated tests to prevent mistakes. The maintainers will also review your code and fix obvious issues. These systems are in place to minimize your worries about the process. Your code contributions are more important than adhering to strict procedures, although completing the checklist will undoubtedly save everyone's time.

Commit Messages

Commit messages should be simple and use easy words that indicate the focus of the commit and its impact on other developers. Summary in the present tense. Use capital case in the first character but do not use title case.

Example

Add imports to Terraform plan result

Don't stress too much about PR titles. The maintainers will help you get the title right.

Licensing

By contributing to PipeCD, you agree that your contributions will be licensed under the Apache License Version 2. Include the following header at the top of your new file(s):

// Copyright 2024 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//     http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Release Note and Breaking Changes

If your change introcudes a user-facing change, please update the following section in your PR description.

**Does this PR introduce a user-facing change?**:
- **How are users affected by this change**:
- **Is this breaking change**:
- **How to migrate (if breaking change)**:

Note that if it's a new breaking change, make sure to complete the two latter questions.

Contributor License Agreement

For any code contribution, please carefully read the following documents:

And signing off your commit with git commit -s (About commit sign-off please read Github docs)

What Happens Next?

The core PipeCD team will monitor the pull requests. Help us by keeping your pull requests consistent with the guidelines mentioned above.