Skip to content

pipedv1: Mask the plugins config in a piped config #6214

@t-kikuc

Description

@t-kikuc

What would you like to be added:

Mask some fields in plugins in a piped config.

We need a discussion on how to realize this feature.

Why is this needed:

In pipedv0, some fields in the piped config were masked to hide secret values on the Web UI.

However, in pipedv1, piped core does not know which fields should be masked.

// Mask masks confidential fields.
func (s *PipedSpec) Mask() {
if len(s.PipedKeyFile) != 0 {
s.PipedKeyFile = maskString
}
if len(s.PipedKeyData) != 0 {
s.PipedKeyData = maskString
}
s.Git.Mask()
s.Notifications.Mask()
if s.SecretManagement != nil {
s.SecretManagement.Mask()
}
// TODO: Mask plugin configs
}

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions