Properly capture the error message via sprintf() before passing to exception constructor. Fixes ruckus#173

ruckus · ruckus · commit 6f264c3805ef · 2017-01-13T06:41:34.000-08:00
diff --git a/lib/Ruckusing/Util/Migrator.php b/lib/Ruckusing/Util/Migrator.php
@@ -217,7 +217,7 @@ public static function get_migration_files($directories, $direction)
             if (!is_dir($path)) {
                 if (mkdir($path, 0755, true) === FALSE) {
                     throw new Ruckusing_Exception(
-                    		"\n\tUnable to create migrations directory at %s, check permissions?", $path,
+                    		sprintf("\n\tUnable to create migrations directory at %s, check permissions?", $path),
                     		Ruckusing_Exception::INVALID_MIGRATION_DIR
                     );
                 }

Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ public static function get_migration_files($directories, $direction)`
`217`	`217`	`if (!is_dir($path)) {`
`218`	`218`	`if (mkdir($path, 0755, true) === FALSE) {`
`219`	`219`	`throw new Ruckusing_Exception(`
`220`		`- "\n\tUnable to create migrations directory at %s, check permissions?", $path,`
	`220`	`+ sprintf("\n\tUnable to create migrations directory at %s, check permissions?", $path),`
`221`	`221`	`Ruckusing_Exception::INVALID_MIGRATION_DIR`
`222`	`222`	`);`
`223`	`223`	`}`