Skip to content

Commit 7233d1a

Browse files
committed
MINOR: [Python][CI] Avoid unconditional use of precompiled headers
The precompiled headers generated during the PyArrow build phase seem to take a lot of disk space (more than 2 GB). Avoiding their unconditional generation should make disk space issues on CI less likely.
1 parent 15cc84d commit 7233d1a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

python/CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -454,7 +454,7 @@ endif()
454454
add_library(arrow_python SHARED ${PYARROW_CPP_SRCS})
455455
target_include_directories(arrow_python PUBLIC ${PYARROW_CPP_ROOT_DIR}
456456
${CMAKE_CURRENT_BINARY_DIR}/pyarrow/src)
457-
if(NOT CMAKE_VERSION VERSION_LESS 3.16)
457+
if(ARROW_USE_PRECOMPILED_HEADERS AND NOT CMAKE_VERSION VERSION_LESS 3.16)
458458
target_precompile_headers(arrow_python PUBLIC
459459
"$<$<COMPILE_LANGUAGE:CXX>:arrow/python/pch.h>")
460460
endif()

python/pyarrow/src/arrow/python/udf.cc

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@
1616
// under the License.
1717

1818
#include "arrow/python/udf.h"
19+
20+
#include "arrow/array/array_nested.h"
1921
#include "arrow/array/builder_base.h"
2022
#include "arrow/buffer_builder.h"
2123
#include "arrow/compute/api_aggregate.h"

0 commit comments

Comments
 (0)