Skip to content

Commit 7265689

Browse files
authored
apacheGH-39297: [C++][FS]: Inform caller of container not-existing when checking for HNS support (apache#39298)
### Rationale for this change An operation checking for Hierarchical Namespace support shouldn't fail completely when the reason for the check failing is the container not existing. We can allow the caller to decide what to do in that situation by returning a result that indicates the check didn't succeed because the container doesn't exist. ### What changes are included in this PR? - Removal of the `azurefs_intern.h/cc` files - Implementation of the check as a free-function instead of a class - Memoization of the result in the `AzureFileSystem` class ### Are these changes tested? Yes. The tests were improved to cover all cases. * Closes: apache#39297 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
1 parent 87865b5 commit 7265689

File tree

6 files changed

+309
-263
lines changed

6 files changed

+309
-263
lines changed

cpp/src/arrow/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -506,8 +506,8 @@ if(ARROW_FILESYSTEM)
506506
filesystem/util_internal.cc)
507507

508508
if(ARROW_AZURE)
509-
list(APPEND ARROW_SRCS filesystem/azurefs.cc filesystem/azurefs_internal.cc)
510-
set_source_files_properties(filesystem/azurefs.cc filesystem/azurefs_internal.cc
509+
list(APPEND ARROW_SRCS filesystem/azurefs.cc)
510+
set_source_files_properties(filesystem/azurefs.cc
511511
PROPERTIES SKIP_PRECOMPILE_HEADERS ON
512512
SKIP_UNITY_BUILD_INCLUSION ON)
513513
endif()

0 commit comments

Comments
 (0)