Convert lab unit test mocks from Python dict to JSON
#220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert the mocks for lab unit tests from Python dicts to JSON files. This makes the mocking of lab unit tests more consistent with how unit tests for most other modules are mocked. This also avoids unnecessarily mocking entire module functions, as only the HTTP requests made by those functions need to be mocked. Since the mocks are only supposed to contain JSON HTTP responses anyway, it makes more sense to keep them as JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the mocks for
labunit tests from Pythondicts to JSON files. This makes the mocking oflabunit tests more consistent with how unit tests for most other modules are mocked. This also avoids unnecessarily mocking entire module functions, as only the HTTP requests made by those functions need to be mocked. Since the mocks are only supposed to contain JSON HTTP responses anyway, it makes more sense to keep them as JSON.I placed the new JSON mocks in the
tests/samples/directory rather than thetests/mocks/directory where the current mocks are located. I'm doing this as part of a larger effort to migrate all the mocks intests/mocks/totests/samplesso that mocks won't be split across two sibling directories.