Working (?) tests

Author: jalada

.gitignore

@@ -12,3 +12,5 @@
 
 # Created when initializing Rails app
 /spec/log
+/spec/tmp
+/log

spec/scan_suppressing_logger/middleware_spec.rb

@@ -15,4 +15,37 @@
       expect(wrappers).to include(ScanSuppressingLogger::RollbarWrapper)
     end
   end
+
+  describe 'Replacing Rails::Rack::Logger' do
+    it 'replaces Rails::Rack::Logger with ScanSuppressingLogger::Middleware' do
+      expect(Rails.application.middleware).to include(ScanSuppressingLogger::Middleware)
+      expect(Rails.application.middleware).not_to include(Rails::Rack::Logger)
+    end
+
+    context 'from a suppressed address' do
+      it 'does not log the request' do
+        # Expect the middleware to be called
+        expect_any_instance_of(ScanSuppressingLogger::Middleware).to receive(:call).and_call_original
+        # Expect the logger to report it was suppressed
+        expect(Rails.logger).to receive(:info).with('Suppressed for 127.0.0.1')
+        # Do not expect the original Rails::Rack::Logger to be called
+        expect_any_instance_of(Rails::Rack::Logger).not_to receive(:call)
+
+        # Make a simulated request to the app
+        env = Rack::MockRequest.env_for('http://example.org/', 'REMOTE_ADDR' => '127.0.0.1')
+        status, headers, body = Rails.application.call(env)
+      end
+    end
+
+    context 'from a non-suppressed address' do
+      it 'logs the request' do
+        # Expect the original Rails::Rack::Logger to be called
+        expect_any_instance_of(Rails::Rack::Logger).to receive(:call).and_call_original
+
+        # Make a simulated request to the app
+        env = Rack::MockRequest.env_for('/', 'REMOTE_ADDR' => '192.0.2.1')
+        status, headers, body = Rails.application.call(env)
+      end
+    end
+  end
 end

spec/spec_helper.rb

@@ -1,16 +1,26 @@
 require "bundler/setup"
 require "rails"
+require "action_controller/railtie"
 require "scan_suppressing_logger"
 
-# Set up a dummy Rails app for testing
+# Setup a dummy Rails app
 module Dummy
   class Application < Rails::Application
     config.root = File.dirname(__FILE__)
-    config.eager_load = false
   end
 end
 
-Dummy::Application.initialize!
+# Impossible to do this in a test; so you only get one shot setting it up.
+Rails.application.configure do
+  config.middleware.swap Rails::Rack::Logger, ScanSuppressingLogger::Middleware, {
+    networks: ['127.0.0.1']
+  }
+
+  config.eager_load = false
+  config.hosts.clear
+end
+
+Rails.application.initialize!
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure