Fix Issue #509

[AydanPirani]

In-progress.

[AydanPirani]

Hey! @GlenDC @soundofspace Got a very rudimentary implementation going, can I get a quick informal review on this before finishing implementation?

[GlenDC]

this file is to be deleted as discussed in the parent isuse

[AydanPirani]

Yup, using this as a temporary driver. Will delete before finishing up.

[GlenDC]

Looks like a good start. Next to my comments and fact that you also want to add a good test suite for this (e.g. as curl/tests.rs) I also would say:

• do not forget about checking the extension ProxyAddress (which defines if you need to set a proxy)
• there might be some other stuff but cannot think of it now
• once your finished with code + tests, also add it to the EchoService core code please

@soundofspace might have some more feedback as well.

Either way, well done. Definitely well on your way in resolving this.

[AydanPirani]

@GlenDC @soundofspace Hey hey! Running into a small issue here: how do I get the body data to convert to Bytes? Can't seem to figure this one out, any pointers would be much appreciated :)

[GlenDC]

@GlenDC @soundofspace Hey hey! Running into a small issue here: how do I get the body data to convert to Bytes? Can't seem to figure this one out, any pointers would be much appreciated :)

👇

rama/src/cli/service/echo.rs

Line 460 in d332fd1

let body = body.collect().await.unwrap().to_bytes();

[AydanPirani]

@GlenDC Got it, thanks. Also, do you have any to check if a Proxy is enabled?

[GlenDC]

@GlenDC Got it, thanks. Also, do you have any to check if a Proxy is enabled?

Probably gonna change a tiny bit in near future but for now you can check if ProxyAddress (https://ramaproxy.org/docs/rama/net/address/struct.ProxyAddress.html) is present in the Context: if let Some(addr) = ctx.get::<ProxyAddress>() { '-x {addr}' }

something like that in hybrid pseudo code

[AydanPirani]

Got it, thanks. And one last thing - is a string a valid body type? I presume not, in that case is this the right approach to testing with a stream?

[GlenDC]

Got it, thanks. And one last thing - is a string a valid body type? I presume not, in that case is this the right approach to testing with a stream?

You are confusing different kinds of echo services. You are linking to a stream echo service. That lives on the transport layer. That's different from the echo service which I was linking you that works with http on the application layer.

The first lives on the transport layer (e.g. tcp) and just echo's back the incoming bytes as-is. You can as a human easily play with it using tooling like telnet. There's a tcp example about it that you can try out.

But this is nothing to do with your work here. Different kind of echo service.