Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update session limiting to take advantage of new 'burst' support in APIs #693

Open
jreiberkyle opened this issue Sep 15, 2022 · 1 comment

Comments

@jreiberkyle
Copy link
Contributor

The APIs have been updated to support 'bursts' of requests. This means that TooManyRequests should no longer be returned if the number of initial requests is below the rate limit. Therefore, the current custom implementation of _Limit, which enforces a delay between requests, is likely no longer needed.

Try replacing _Limiter with asyncio-throttle and rerun session_configuration.py. Make note of total run time vs original and number of TooManyRequests errors. Given improved performance, implement the change and update docs.

@tbarsballe
Copy link
Contributor

This may help with the problems described in #1050 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants