Skip to content

Commit 95769df

Browse files
pjcdawkinsclaude
andcommitted
refactor: use craft command for PHP build
Use static-php-cli's craft command instead of separate download and build commands. This eliminates the duplication of the extensions list and aligns with the configuration-driven approach in craft.yml. Also remove invalid with-strip-php option from craft.yml (stripping is the default behavior). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 2674885 commit 95769df

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ internal/legacy/archives/php_darwin_$(GOARCH):
3838

3939
internal/legacy/archives/php_linux_$(GOARCH):
4040
mkdir -p internal/legacy/archives
41-
cd ext/static-php-cli && SPC_USE_ARCH=$(GOARCH) ./bin/spc-alpine-docker download --with-php=$(PHP_VERSION) --for-extensions=curl,filter,openssl,pcntl,phar,posix,zlib
42-
cd ext/static-php-cli && SPC_USE_ARCH=$(GOARCH) ./bin/spc-alpine-docker build curl,filter,openssl,pcntl,phar,posix,zlib --build-cli
41+
cp ext/craft.yml ext/static-php-cli/craft.yml
42+
cd ext/static-php-cli && SPC_USE_ARCH=$(GOARCH) ./bin/spc-alpine-docker craft craft.yml
4343
cp ext/static-php-cli/buildroot/bin/php $(PHP_BINARY_PATH)
4444

4545
PHP_WINDOWS_REMOTE_FILENAME := "php-$(PHP_VERSION)-nts-Win32-vs16-x64.zip"

ext/craft.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ build-options:
2121
with-clean: false
2222
with-suggested-libs: false
2323
with-upx-pack: true
24-
with-strip-php: true
2524

2625
download-options:
2726
prefer-pre-built: true

0 commit comments

Comments
 (0)