Do not require SSH permission to list mounts

Author: pjcdawkins

src/Command/Mount/MountListCommand.php

@@ -3,8 +3,9 @@
 namespace Platformsh\Cli\Command\Mount;
 
 use Platformsh\Cli\Command\CommandBase;
-use Platformsh\Cli\Model\AppConfig;
 use Platformsh\Cli\Model\Host\LocalHost;
+use Platformsh\Cli\Model\RemoteContainer\BrokenEnv;
+use Platformsh\Cli\Model\RemoteContainer\Worker;
 use Platformsh\Cli\Service\Table;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -36,23 +37,48 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        $host = $this->selectHost($input, getenv($this->config()->get('service.env_prefix') . 'APPLICATION'));
         /** @var \Platformsh\Cli\Service\Mount $mountService */
         $mountService = $this->getService('mount');
-        if ($host instanceof LocalHost) {
-            /** @var \Platformsh\Cli\Service\RemoteEnvVars $envVars */
-            $envVars = $this->getService('remote_env_vars');
-            $config = (new AppConfig($envVars->getArrayEnvVar('APPLICATION', $host)));
+        if (($applicationEnv = getenv($this->config()->get('service.env_prefix') . 'APPLICATION'))
+            && !LocalHost::conflictsWithCommandLineOptions($input, $this->config()->get('service.env_prefix'))) {
+            $this->debug('Selected host: localhost');
+            $config = json_decode(base64_decode($applicationEnv), true) ?: [];
             $mounts = $mountService->mountsFromConfig($config);
+            $appName = $config['name'];
+            $appType = strpos($appName, '--') !== false ? 'worker' : 'app';
+            if (empty($mounts)) {
+                $this->stdErr->writeln(sprintf(
+                    'No mounts found in config variable: <info>%s</info>',
+                    $this->config()->get('service.env_prefix') . 'APPLICATION'
+                ));
+
+                return 0;
+            }
         } else {
+            $this->chooseEnvFilter = $this->filterEnvsMaybeActive();
+            $this->validateInput($input);
+            $environment = $this->getSelectedEnvironment();
             $container = $this->selectRemoteContainer($input);
+            if ($container instanceof BrokenEnv) {
+                $this->stdErr->writeln(sprintf(
+                    'Unable to find deployment information for the environment: %s',
+                    $this->api()->getEnvironmentLabel($environment, 'error')
+                ));
+                return 1;
+            }
             $mounts = $mountService->mountsFromConfig($container->getConfig());
-        }
-
-        if (empty($mounts)) {
-            $this->stdErr->writeln(sprintf('No mounts found on host: <info>%s</info>', $host->getLabel()));
+            $appName = $container->getName();
+            $appType = $container instanceof Worker ? 'worker' : 'app';
+            if (empty($mounts)) {
+                $this->stdErr->writeln(sprintf(
+                    'No mounts found on environment %s, %s <info>%s</info>',
+                    $this->api()->getEnvironmentLabel($environment),
+                    $appType,
+                    $appName
+                ));
 
-            return 1;
+                return 0;
+            }
         }
 
         if ($input->getOption('paths')) {
@@ -70,7 +96,15 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         /** @var \Platformsh\Cli\Service\Table $table */
         $table = $this->getService('table');
-        $this->stdErr->writeln(sprintf('Mounts on <info>%s</info>:', $host->getLabel()));
+        if ($this->hasSelectedEnvironment()) {
+            $this->stdErr->writeln(sprintf('Mounts on environment %s, %s <info>%s</info>:',
+                $this->api()->getEnvironmentLabel($this->getSelectedEnvironment()),
+                $appType,
+                $appName
+            ));
+        } else {
+            $this->stdErr->writeln(sprintf('Mounts on %s <info>%s</info>:', $appType, $appName));
+        }
         $table->render($rows, $this->tableHeader);
 
         return 0;