wrong validation for ssh keys

Marcos Rodriguez Ordieres · Marcos Rodriguez Ordieres · commit f336d9726ed3 · 2024-10-01T13:59:56.000+02:00
diff --git a/src/model/SshKey.ts b/src/model/SshKey.ts
@@ -103,7 +103,7 @@ export class SshKey extends Ressource {
       return false;
     }
     const match = value.split(" ", 3);
-    const [type] = match;
+
     let key;
 
     try {
@@ -112,7 +112,7 @@ export class SshKey extends Ressource {
       return false;
     }
 
-    if (!["ssh-rsa", "ssh-ed25519", "ssh-ecdsa"].includes(type) || !key) {
+    if (!key) {
       return false;
     }
     return true;

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ export class SshKey extends Ressource {`
`103`	`103`	`return false;`
`104`	`104`	`}`
`105`	`105`	`const match = value.split(" ", 3);`
`106`		`- const [type] = match;`
	`106`	`+`
`107`	`107`	`let key;`
`108`	`108`
`109`	`109`	`try {`
`@@ -112,7 +112,7 @@ export class SshKey extends Ressource {`
`112`	`112`	`return false;`
`113`	`113`	`}`
`114`	`114`
`115`		`- if (!["ssh-rsa", "ssh-ed25519", "ssh-ecdsa"].includes(type) \|\| !key) {`
	`115`	`+ if (!key) {`
`116`	`116`	`return false;`
`117`	`117`	`}`
`118`	`118`	`return true;`