Referencing Device in cache Map can cause errors when the app goes behind a Proxy

[d0rianb]

I encountered this issue when using a WebComponent that embeds a PlayCanvas application inside a Vue project.
The component instance is accessed through a Vue $ref, which is actually a Proxy object.
When I call a method that alter the rendering process on the component from outside (for example to add a gizmo), the application fails to retrieve the GraphicsDevice from the internal cache.
This happens because the Proxy changes the memory reference of the application object and all of its childrens, therefore the device lookup no longer matches the original cached reference.

engine/src/platform/graphics/device-cache.js

Lines 26 to 27 in 4257ba5

	if (!this._cache.has(device)) {
	this._cache.set(device, onCreate());

It then try to call the onCreate argument, which is often undefined ex :

engine/src/scene/shader-lib/get-program-library.js

Line 20 in 4257ba5

const library = programLibraryDeviceCache.get(device);

Possible fix : I think changing the DeviceCache map from Map<GraphicsDevice, any> to Map<string, any> using the device.canvas.id as key could solve this issue. Maybe it has side effect on AR/VR devices?

[mvaligursky]

Thanks for reporting this issue! I'm working on understanding the root cause before implementing a fix.

Question about the Vue Proxy scenario:
You mentioned that the component instance is accessed through a Vue $ref, which is a Proxy object. However, I want to clarify the exact mechanism causing the cache miss, because Vue Proxies typically shouldn't change object identity in the way described.
When you access a property through a Vue Proxy like this:

const device1 = vueComponentRef.app.graphicsDevice;
const device2 = vueComponentRef.app.graphicsDevice;
// device1 === device2 should be true

The Proxy should return the same underlying object both times, so Map.has(device) should still work correctly.

[d0rianb]

Thanks for investigating on this issue.

The problem occurs when the initialization happens before the object is handled by the Proxy.
For example, the context is initialized by a web component and, once it is ready, it is then retrieved by the Vue ref.

<template>
  <pc-viewer></pc-viewer>
</template>

<script>
const viewerElement = ref(null)
  
onMounted(() => {
  viewerElement.value = document.querySelector('pc-viewer')
  viewerElement.addRenderElement() // cache error because the graphic context was initialised by the WebComponent
})
</script>

[mvaligursky]

@marklundin - any thoughts on this Mark? Have you had similar issues on React with this?

[marklundin]

I think the Proxy is specific to Vue. it's not something I've encountered with the react library

[ComeradeCharon]

Try to Use key based caching instead of relying on memory reference.