Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to add metadata like annotations to constraint automatically #322

Closed
Mattes83 opened this issue Aug 30, 2022 · 3 comments
Closed

Allow to add metadata like annotations to constraint automatically #322

Mattes83 opened this issue Aug 30, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Mattes83
Copy link
Contributor

Mattes83 commented Aug 30, 2022 •
edited
Loading

Hi,

we recently switched to konstraint and I think this great tool will save us a lot of work in the future.

Unfortunately there is a small drawback. We are using argo cd to rollout new constraints and therefore we need an annotation on the constraints, see https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#skip-dry-run-for-new-custom-resources-types

If I see it correctly there is no way to do this with konstraint, right?
@jpreese
Copy link
Collaborator

jpreese commented Aug 30, 2022

At the moment there is not. It has been discussed briefly in the past, but has yet to be implemented.

Relates to: #236

@jpreese jpreese added the enhancement New feature or request label Aug 30, 2022
@Mattes83 Mattes83 mentioned this issue Aug 31, 2022
Merged
@Mattes83
Copy link
Contributor Author

Mattes83 commented Sep 6, 2022

I opened a pull request to address this. Do you want to have a look? #324

@Mattes83
Copy link
Contributor Author

fixed by #324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpreese @Mattes83