Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify to run jobs after repo-local CI checks have passed #84

Closed
rpatterson opened this issue Dec 27, 2021 · 3 comments · Fixed by #87
Closed

Clarify to run jobs after repo-local CI checks have passed #84

rpatterson opened this issue Dec 27, 2021 · 3 comments · Fixed by #87

Comments

@rpatterson
Copy link
Member

I've been using Plone's Jenkins through the mister-roboto bot comment @jenkins-plone-org please run jobs directive for some time, albeit as an infrequent contributor, and read that comment many times and I only just recently came to understand something that seems important to communicate to less familiar contributors. Namely that's it's best to get the repo-specific CI checks (e.g. GitHub actions, Travis CI, etc.) to passing and then launch the much longer running Plone Jenkins jobs as a final check before seeking review. It seems worthwhile to improve that bot comment to make this clear.

@gforcada
Copy link
Member

Hi @rpatterson the comment message is at: https://github.com/plone/mr.roboto/blob/master/src/mr.roboto/src/mr/roboto/subscriber.py#L623 might you have a first go on the re-wording? 🙂

@rpatterson
Copy link
Member Author

Hi @rpatterson the comment message is at: https://github.com/plone/mr.roboto/blob/master/src/mr.roboto/src/mr/roboto/subscriber.py#L623 might you have a first go on the re-wording? slightly_smiling_face

Certainly happy to if I get the time, but I'm not sure when I might. I mainly reported the issue just to get it down somewhere. Feel free to close with a "Feel free to re-open if you want to tackle it" comment or manage this issue how you like. If someone ever does get to this, your pointer to the exact line of code is very helpful knowledge transfer and will save them time, thanks!

@rpatterson
Copy link
Member Author

rpatterson commented Dec 29, 2021

May also want to consider making it clearer how to find the Plone Jenkins docs for PR jobs.

rpatterson added a commit that referenced this issue Dec 29, 2021
Clarify that usually contributors should get all other checks passing before running the
Plone Jenkins PR jobs and add a link to the Plone Jenkins docs.  Also fix some typos and
do some other editing for brevity and clarity.

Fixes #84
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants