Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live site doesn't get updated on release #72

Open
jonaspiterek opened this issue Sep 11, 2024 · 3 comments
Open

Live site doesn't get updated on release #72

jonaspiterek opened this issue Sep 11, 2024 · 3 comments
Assignees

Comments

@jonaspiterek
Copy link
Member

With the last release the live site didn't update with the changes I made.

@fredvd
Copy link
Member

fredvd commented Sep 11, 2024

@fredvd Which changes did you make, and how I can I check (preferably visual, or otherwise commits of changes on filesystem) that I can check these are not activated on live or in the current 1.0.13 release and are visible in the latest deploy to the testing instance of plone.de ?

@jonaspiterek
Copy link
Member Author

@fredvd When this page: https://plone.de/warum-plone/wer-benutzt-plone looks like on the image I uploaded, the changes got applied.

image

@fredvd
Copy link
Member

fredvd commented Sep 28, 2024

@jonaspiterek From what I have reverse checked, all commits with your styling update for the logo have been merged here. c9a6bfa#diff-aa80192de24e7324e2ea2d706f49a84a55334ced4a63d7744e3ed7833cc3fa1f

When I update the project locally and start and check the css in the web devconsole and compare it to the current live site, they are identical. So the current code on main has been deployed fine, just as the previous times.

Did you check this yourself before opening the issue?

Something else is likely going on in the generated css why your override/change for the max-width is not working at the moment.

Left localhost dev instance, right production:

compare-localhost-live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants