Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose valid id if id is provided for content creation #1614

Closed
wants to merge 1 commit into from

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Mar 31, 2023

Fix #1613

@mister-roboto
Copy link

@ksuess thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@netlify
Copy link

netlify bot commented Mar 31, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 696edbc
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6427060db6577e000854ed63

@ksuess ksuess marked this pull request as draft March 31, 2023 16:48
@tisto
Copy link
Member

tisto commented Aug 25, 2023

@ksuess can we close this PR? The discussion is still in #1613 if we want to move on from there.

@tisto tisto closed this Aug 25, 2023
@tisto tisto deleted the add-content-with-id branch August 25, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choose valid id if id is provided for content creation
3 participants