Skip to content

Commit 25eaf6d

Browse files
authored
Merge pull request #392 from plone/maintenance-pnpm
Package maintenance
2 parents 22febdb + 3738813 commit 25eaf6d

23 files changed

+2046
-3203
lines changed
File renamed without changes.

.github/workflows/meta.yml

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -25,24 +25,21 @@ on:
2525

2626
jobs:
2727
qa:
28-
uses: plone/meta/.github/workflows/qa.yml@main
29-
test:
30-
uses: plone/meta/.github/workflows/test.yml@main
28+
uses: plone/meta/.github/workflows/[email protected]
3129
coverage:
32-
uses: plone/meta/.github/workflows/coverage.yml@main
30+
uses: plone/meta/.github/workflows/coverage.yml@2.x
3331
dependencies:
34-
uses: plone/meta/.github/workflows/dependencies.yml@main
32+
uses: plone/meta/.github/workflows/dependencies.yml@2.x
3533
release_ready:
36-
uses: plone/meta/.github/workflows/release_ready.yml@main
34+
uses: plone/meta/.github/workflows/release_ready.yml@2.x
3735
circular:
38-
uses: plone/meta/.github/workflows/circular.yml@main
36+
uses: plone/meta/.github/workflows/circular.yml@2.x
3937

4038
##
4139
# To modify the list of default jobs being created add in .meta.toml:
4240
# [github]
4341
# jobs = [
4442
# "qa",
45-
# "test",
4643
# "coverage",
4744
# "dependencies",
4845
# "release_ready",
@@ -57,13 +54,6 @@ jobs:
5754
# os_dependencies = "git libxml2 libxslt"
5855
##
5956

60-
##
61-
# To test against a specific matrix of python versions
62-
# when running tests jobs, add in .meta.toml:
63-
# [github]
64-
# py_versions = "['3.12', '3.11']"
65-
##
66-
6757

6858
##
6959
# Specify additional jobs in .meta.toml:

.github/workflows/test-matrix.yml

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
# Generated from:
2+
# https://github.com/plone/meta/tree/main/src/plone/meta/default
3+
# See the inline comments on how to expand/tweak this configuration file
4+
name: Tests
5+
6+
on:
7+
push:
8+
9+
jobs:
10+
build:
11+
permissions:
12+
contents: read
13+
pull-requests: write
14+
strategy:
15+
# We want to see all failures:
16+
fail-fast: false
17+
matrix:
18+
os:
19+
- ["ubuntu", "ubuntu-latest"]
20+
config:
21+
# [Python version, visual name, tox env]
22+
- ["3.13", "6.2 on py3.13", "py313-plone62"]
23+
- ["3.10", "6.2 on py3.10", "py310-plone62"]
24+
- ["3.13", "6.1 on py3.13", "py313-plone61"]
25+
- ["3.10", "6.1 on py3.10", "py310-plone61"]
26+
27+
runs-on: ${{ matrix.os[1] }}
28+
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
29+
name: ${{ matrix.config[1] }}
30+
steps:
31+
- uses: actions/checkout@v4
32+
with:
33+
persist-credentials: false
34+
- name: Set up Python
35+
uses: actions/setup-python@v5
36+
with:
37+
python-version: ${{ matrix.config[0] }}
38+
allow-prereleases: true
39+
- name: Pip cache
40+
uses: actions/cache@v4
41+
with:
42+
path: ~/.cache/pip
43+
key: ${{ runner.os }}-pip-${{ matrix.config[0] }}-${{ hashFiles('setup.*', 'tox.ini') }}
44+
restore-keys: |
45+
${{ runner.os }}-pip-${{ matrix.config[0] }}-
46+
${{ runner.os }}-pip-
47+
- name: Install dependencies
48+
run: |
49+
python -m pip install --upgrade pip
50+
pip install tox
51+
- name: Test
52+
run: tox -e ${{ matrix.config[2] }}

.meta.toml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@
33
# See the inline comments on how to expand/tweak this configuration file
44
[meta]
55
template = "default"
6-
commit-id = "770f41af"
6+
commit-id = "2.0.1.dev0"
77

88
[pyproject]
9-
codespell_skip = "*.css.map,package-lock.json"
9+
codespell_skip = "*.css.map,pnpm-lock.yaml"
10+
11+
[tox]
12+
test_matrix = {"6.2" = ["3.13", "3.10"], "6.1" = ["3.13", "3.10"]}

CONTRIBUTING.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Please see http://docs.plone.org/develop/coredev/docs/guidelines.html
1+
Please see https://6.docs.plone.org/contributing/core/

HOWTO_DEVELOP.md

Lines changed: 85 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,85 @@
1+
## Install package manager
2+
3+
### pnpm
4+
5+
Using corepack:
6+
7+
```shell
8+
corepack prepare pnpm@latest --activate
9+
```
10+
11+
or using `npm`:
12+
13+
```shell
14+
npm install -g pnpm@latest
15+
```
16+
17+
Verify the latest version.
18+
19+
```shell
20+
pnpm --version
21+
```
22+
23+
### Install dependencies
24+
25+
In order to develop plonetheme.barceloneta you need to execute on the root of the package::
26+
27+
```shell
28+
pnpm install
29+
```
30+
31+
You can also updated dependencies with
32+
33+
```shell
34+
pnpm update
35+
```
36+
37+
After executing this you can run the following command to watch for any scss changes
38+
in the path `plonetheme.barceloneta/scss`::
39+
40+
```shell
41+
pnpm watch
42+
```
43+
44+
This will make sure that the many .scss files are compiled to .css on the fly
45+
and then copied over to the theme.
46+
47+
If you simply want to compile all resources before a release run::
48+
49+
```shell
50+
pnpm build
51+
```
52+
53+
54+
## Release Instructions
55+
56+
```{note}
57+
You need the correct access rights to publish to npm or pypi.
58+
```
59+
60+
- First create a pypi release using zest.releaser. This tool also creates the correct tag based on the setup.py version.
61+
- After the pypi release edit the release version in package.json.
62+
Or better yet, run something like `pnpm version 3.2.0-alpha.5`
63+
- Run: `pnpm publish`
64+
65+
66+
### Pre-Releases
67+
68+
Based on https://survivejs.com/maintenance/packaging/publishing/#publishing-a-pre-release-version
69+
70+
- Change version in package.json to corresponding version in setup.py
71+
- You can also use `pnpm version 3.0.0-beta1` - This will change the version in package.json and create a git tag.
72+
- `pnpm publish --tag beta` - Publish the package under beta tag.
73+
- Mark beta release as latest with `npm dist-tag add @plone/plonetheme-barceloneta-base@3.0.0-beta1 latest``
74+
75+
To consume the test version, users have to use `pnpm install @plone/plonetheme-barceloneta-base@beta`.
76+
77+
78+
## Theme
79+
80+
See `plonetheme.barceloneta/plonetheme/barceloneta/theme/rules.xml` for the relevant Diazo theme rules.
81+
82+
83+
## Fonts
84+
85+
Read `plonetheme.barceloneta/plonetheme/barceloneta/theme/roboto/README.rst` if you need to update the shipped fonts.

HOWTO_DEVELOP.rst

Lines changed: 0 additions & 28 deletions
This file was deleted.

MANIFEST.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ exclude yarn.lock
1111
exclude package.json
1212
exclude postcss.config.js
1313
exclude .stylelint*
14+
exclude pnpm-lock.yaml

NPM_RELEASE.rst

Lines changed: 0 additions & 26 deletions
This file was deleted.

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Barceloneta
22

3-
Classic theme resources for Plone 6 - based on Bootstrap 5
3+
Classic-UI theme resources for Plone 6 - based on Bootstrap 5
44

55
This package provides scss resources to build your own theme based on the Plone default theme for (backend rendered) Classic UI of Plone.
66

@@ -15,10 +15,15 @@ https://github.com/plone/plonetheme.barceloneta/blob/master/CHANGES.md
1515
## Source Code and Contribution
1616

1717
### Contributors
18-
Please read the document [Contributing to Plone](https://6.docs.plone.org/contributing/index.html). Also consult the document [Contributing to `plone.api`](https://6.docs.plone.org/plone.api/contribute/index.html).
18+
19+
Please read the document [Contributing to Plone](https://6.docs.plone.org/contributing/index.html).
20+
21+
Also consult the development notes [Develop Barceloneta Theme](https://github.com/plone/plonetheme.barceloneta/blob/master/HOWTO_DEVELOP.md).
1922

2023
### Source-Code
24+
2125
Plone code repository hosted at Github https://github.com/plone/plonetheme.barceloneta.
2226

2327
### Issues
28+
2429
Please use the [Issue-Tracker](https://github.com/plone/plonetheme.barceloneta/issues)

0 commit comments

Comments
 (0)