Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent rendering recursion when we have blocks but no blocks_layout #6753

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Feb 13, 2025

Caution

The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.



If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6752
Closes #6742

This PR changes the following:

  • deleteBlock function to attempt to re-use any existing block data if the blocks_layout is empty before resetting the blocks data completely
  • The BlocksForm component will wait until it has rendered before trying to update the state, preventing it from getting stuck in an update loop

Copy link

netlify bot commented Feb 13, 2025

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 5ce7466
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67ae32b83223db00088ab663

@JeffersonBledsoe JeffersonBledsoe force-pushed the handle-existing-data-in-delete-block branch from ef0ba38 to 4ad982a Compare February 13, 2025 17:33
@JeffersonBledsoe JeffersonBledsoe changed the title Handle existing data in delete block Prevent rendering recursion when we have blocks but no blocks_layout Feb 13, 2025
JeffersonBledsoe added a commit to pretagov/nsw-design-system-plone6 that referenced this pull request Feb 13, 2025
JeffersonBledsoe added a commit to pretagov/nsw-design-system-plone6 that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant