Detect error in json using key in close_session() and close_tab()

plotly · Sep 6, 2024 · 0032a62 · 0032a62
1 parent 8eb068f
commit 0032a62
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/devtools/browser.py b/devtools/browser.py
@@ -168,9 +168,8 @@ async def close_tab(self, target):
             command="Target.closeTarget",
             params={"targetId": target},
         )
-        error = self.protocol.get_error(response)
-        if error:
-            raise RuntimeError("Could not close tab") from Exception(error)
+        if "error" in response:
+            raise RuntimeError("Could not close tab") from Exception(response["error"])
         print(f"The tab {target} has been closed")
         self.remove_tab(target)
         return response

diff --git a/devtools/target.py b/devtools/target.py
@@ -50,9 +50,10 @@ async def close_session(self, session):
             command="Target.detachFromTarget",
             params={"sessionId": session},
         )
-        error = self.protocol.get_error(response)
-        if error:
-            raise RuntimeError("Could not close session") from Exception(error)
+        if "error" in response:
+            raise RuntimeError("Could not close session") from Exception(
+                response["error"]
+            )
         print(f"The session {session} has been closed")
         self.remove_session(session)
         return response