-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aria-hidden=true and maybe just add hidden (HTML5) #292
Comments
It used to be |
What? Wasn't the honeypot one of our best performing mechanisms?! |
I hava tested the comments with Voice Over. I have testest the HTML5 "hidden" Attribut in Chrome and it worked better. So I will test that for like a week or two on our site and see, if spam bots get trough that. If not, "hidden" would be a good option. In general is the recommendation is, to use HTML5 and not Aria if possible. |
What is the recommendation here? As VoiceOver should be used with Safari and Chrome/FF has more issues with it, I'm hesitating to change here anything. What do you think @00travelgirl00 @2ndkauboy @websupporter ? |
@Zodiac1978 Voice Over should be used with Safari or Firefox. Chrome has many issues with Voice Over. Also the Stats shows, that only 1.4% of Voice Over users uses Chrome in Mac. Its different for other Screen Readers like Jaws. |
Okay, but "What is the recommendation here?" How do we proceed? Should we merge the change or not? |
Moved this to future release :) |
@Zodiac1978 The automated tool checks if a form control has an accessible name. In this case, even if the form control is hidden from sight and screen reader, it must have an accessible name to pass the WAVE test.
The aria-label can be anything, because it is never announced or visible. I made a codepen with both options, with and without adding aria-label. The the first one fails, the second one passes in WAVE. |
@rianrietveld This issue is about switching from Please see: 3e90f5f Maybe you can help for this question here too. :) For the new issue reported in the forums I created a new issue: #434 |
@Zodiac1978 about using theHTML5 attribute hidden: But hiding with But whatever you choose, keep the HTML valid, so add an accessible name to the textarea (using a label or an aria-label). |
@rianrietveld Unfortunately But as @00travelgirl00 pointed out:
So we would switch to As a first step we will add the label. Thanks for helping out! |
Support in IE can be simulated with CSS:
|
After some reading about accessibility I would like to recommend removing
aria-hidden=true
, because it is meant for elements with multiple states (like collapsing items).antispam-bee/antispam_bee.php
Line 1210 in 9c97b84
If we want to hide forever it seems that
display: none;
is sufficient. Maybe we could addhidden
as this has good support in modern browsers:https://caniuse.com/#search=hidden
But it seems that this is necessary to hide content from screen readers:
https://web.wsu.edu/accessibility-guides/hidden-content/
https://developer.paciellogroup.com/blog/2016/01/the-state-of-hidden-content-support-in-2016/
Can you confirm @00travelgirl00 ?
The text was updated successfully, but these errors were encountered: