Coercion matcher sees :schema-generators.complete/missing

[gfredericks]

I've isolated some strange behavior that I suspect is a bug, or else I'm misunderstanding how the coercion matchers are supposed to be used.

The following test (that I wrote to explain this) fails:

(deftest stringificator-test
  (is (not= ":schema-generators.complete/missing"
            (:foo
             (complete/complete
              {}
              {:foo s/Str}
              {s/Str str})))))

The coercion matcher function (str in this case) is being passed the keyword :schema-generators.complete/missing, which I think is the bug.

It looks like the main reason this doesn't have more pervasive effects is that the default coercion matchers in the schema library will throw exceptions in various ways when passed a keyword, and are wrapped in exception handling that suppresses those exceptions.

[w01fe]

Thanks for the report. Yeah, it looks like we should check for ::missing first and directly fall through to the completion rather than calling the coercion first in that case. Does that seem like the right behavior to you? (PR welcome!)

[gfredericks]

I haven't analyzed the code yet, but that certainly sounds plausible.

I'll look at it soon and make a PR if that fix is straightforward.

Thanks!