Skip to content

Commit 9c471fb

Browse files
make build logs viewable if even if changelogs aren't, fix config page error message
1 parent 191c281 commit 9c471fb

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

assets/src/components/Build.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ function Changelog({ build: { changelogs } }) {
446446
export default function Build() {
447447
const { buildId } = useParams()
448448
const [tab, setTab] = useState('progress')
449-
const { data, loading, subscribeToMore } = useQuery(BUILD_Q, { variables: { buildId }, fetchPolicy: 'cache-and-network' })
449+
const { data, subscribeToMore } = useQuery(BUILD_Q, { variables: { buildId }, fetchPolicy: 'cache-and-network', errorPolicy: 'ignore' })
450450
const { setBreadcrumbs } = useContext(BreadcrumbsContext)
451451

452452
useEffect(() => {
@@ -464,7 +464,7 @@ export default function Build() {
464464
}
465465
}, [buildId, subscribeToMore])
466466

467-
if (!data || loading) {
467+
if (!data) {
468468
return (
469469
<LoopingLogo
470470
scale="0.75"

assets/src/components/Configuration.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -387,15 +387,6 @@ export default function Configuration() {
387387

388388
useEnsureCurrent(repo)
389389

390-
if (!data) {
391-
return (
392-
<LoopingLogo
393-
scale="0.75"
394-
dark
395-
/>
396-
)
397-
}
398-
399390
if (error) {
400391
return (
401392
<Box fill>
@@ -407,6 +398,15 @@ export default function Configuration() {
407398
)
408399
}
409400

401+
if (!data) {
402+
return (
403+
<LoopingLogo
404+
scale="0.75"
405+
dark
406+
/>
407+
)
408+
}
409+
410410
return (
411411
<EditConfiguration
412412
application={data.application}

0 commit comments

Comments
 (0)