test: lua folder implementation (#538)

* test lua folder implementation

* add error when lua script is empty

* add error when lua script is empty

Author: zreigz

pkg/manifests/template/helm.go

@@ -200,7 +200,7 @@ func (h *helm) luaValues(svc *console.ServiceDeploymentForAgent) (map[string]int
 		return nil, valuesFiles, fmt.Errorf("no service found")
 	}
 
-	if svc.Helm == nil || (svc.Helm.LuaScript == nil && svc.Helm.LuaFile == nil) {
+	if svc.Helm == nil || (svc.Helm.LuaScript == nil && svc.Helm.LuaFile == nil && svc.Helm.LuaFolder == nil) {
 		return newValues, valuesFiles, nil
 	}
 
@@ -228,16 +228,18 @@ func (h *helm) luaValues(svc *console.ServiceDeploymentForAgent) (map[string]int
 			return nil, valuesFiles, fmt.Errorf("failed to read lua file %s: %w", *svc.Helm.LuaFile, err)
 		}
 		luaString = string(luaContents)
-	default:
-		return nil, valuesFiles, fmt.Errorf("no lua script or file provided")
 	}
 
 	if svc.Helm.LuaFolder != nil && len(*svc.Helm.LuaFolder) > 0 {
 		luaFolder, err := h.luaFolder(svc, *svc.Helm.LuaFolder)
 		if err != nil {
 			return nil, valuesFiles, err
 		}
-		luaString = luaFolder + "\n\n" + luaString
+		luaString = luaFolder + luaString
+	}
+
+	if luaString == "" {
+		return nil, valuesFiles, fmt.Errorf("no lua script, file, or folder provided")
 	}
 
 	// Execute the Lua script
@@ -323,7 +325,7 @@ func (h *helm) luaFolder(svc *console.ServiceDeploymentForAgent, folder string)
 
 	luaFileContents := make([]string, 0)
 	for _, file := range luaFiles {
-		luaContents, err := os.ReadFile(file)
+		luaContents, err := os.ReadFile(filepath.Join(h.dir, file))
 		if err != nil {
 			return "", fmt.Errorf("failed to read lua file %s: %w", file, err)
 		}

pkg/manifests/template/helm_test.go

@@ -158,5 +158,28 @@ var _ = Describe("Helm template", Ordered, func() {
 			Expect(ns.GetFinalizers()).To(HaveExactElements("a", "b", "c"))
 
 		})
+
+		It("should successfully read lua folder", func() {
+			// check lua script when throw error
+			dir := filepath.Join("..", "..", "..", "test", "helm", "lua-merge-empty")
+
+			svc.Helm = &console.ServiceDeploymentForAgent_Helm{
+				IgnoreHooks: lo.ToPtr(false),
+			}
+
+			svc.Helm.LuaFolder = lo.ToPtr("lua")
+
+			resp, err := NewHelm(dir).Render(svc, mapper)
+			Expect(err).NotTo(HaveOccurred())
+			Expect(len(resp)).To(Equal(3))
+			var ns unstructured.Unstructured
+			for _, i := range resp {
+				if i.GetName() == "result" {
+					ns = i
+				}
+			}
+			Expect(ns.GetFinalizers()).To(HaveExactElements("a", "b", "c"))
+
+		})
 	})
 })

test/helm/lua-merge-empty/lua/a.lua

@@ -0,0 +1,6 @@
+values = {}
+
+local baseStr = fs.read("templates/base.yaml")
+local patchStr = fs.read("templates/patch.yaml")
+local base = encoding.yamlDecode(baseStr)
+local patch = encoding.yamlDecode(patchStr)

test/helm/lua-merge-empty/lua/b.lua

@@ -0,0 +1,2 @@
+local result, err = utils.merge(base, patch)
+values["items"] = result["metadata"]["finalizers"]

test/helm/lua-merge-empty/lua/c.lua

@@ -0,0 +1 @@
+values["items"] = result["metadata"]["finalizers"]