Fix log message (#429)

michaeljguarino · web-flow · commit d0a83e0f7aa7 · 2025-05-09T21:06:45.000-04:00
this technically internally panics when it tries to stringify before logging
diff --git a/pkg/controller/service/reconciler_scraper.go b/pkg/controller/service/reconciler_scraper.go
@@ -53,7 +53,12 @@ func (s *ServiceReconciler) ScrapeKube(ctx context.Context) {
 	}
 
 	serviceMesh := cache.ServiceMesh(hasEBPFDaemonSet)
-	logger.Info("detected service mesh", "serviceMesh", serviceMesh)
+	if serviceMesh == nil {
+		logger.Info("no service mesh detected")
+	} else {
+		logger.Info("detected service mesh", "serviceMesh", serviceMesh)
+	}
+
 	if err := s.consoleClient.RegisterRuntimeServices(runtimeServices, s.GetDeprecatedCustomResources(ctx), nil, serviceMesh); err != nil {
 		logger.Error(err, "failed to register runtime services, this is an ignorable error but could mean your console needs to be upgraded")
 	}

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,12 @@ func (s *ServiceReconciler) ScrapeKube(ctx context.Context) {`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`serviceMesh := cache.ServiceMesh(hasEBPFDaemonSet)`
`56`		`- logger.Info("detected service mesh", "serviceMesh", serviceMesh)`
	`56`	`+ if serviceMesh == nil {`
	`57`	`+ logger.Info("no service mesh detected")`
	`58`	`+ } else {`
	`59`	`+ logger.Info("detected service mesh", "serviceMesh", serviceMesh)`
	`60`	`+ }`
	`61`	`+`
`57`	`62`	`if err := s.consoleClient.RegisterRuntimeServices(runtimeServices, s.GetDeprecatedCustomResources(ctx), nil, serviceMesh); err != nil {`
`58`	`63`	`logger.Error(err, "failed to register runtime services, this is an ignorable error but could mean your console needs to be upgraded")`
`59`	`64`	`}`