Skip to content

Commit 83f89ce

Browse files
authored
fix: allow both google and gcp provider (#827)
* fix: allow both google and gcp provider Signed-off-by: David van der Spek <[email protected]> * fix: also update postgres Signed-off-by: David van der Spek <[email protected]> --------- Signed-off-by: David van der Spek <[email protected]>
1 parent a30cdc9 commit 83f89ce

File tree

26 files changed

+76
-61
lines changed

26 files changed

+76
-61
lines changed

airflow/helm/airflow/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: airflow
33
description: A Helm chart for airflow deployable on plural
44
type: application
5-
version: 0.3.38
5+
version: 0.3.39
66
appVersion: "2.6.3"
77
sources:
88
- https://github.com/pluralsh/plural-artifacts/airflow/helm/airflow

airflow/helm/airflow/values.yaml.tpl

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{ $isGcp := or (eq .Provider "google") (eq .Provider "gcp") }}
12
global:
23
application:
34
links:
@@ -80,13 +81,13 @@ airflow:
8081
else:
8182
return {}
8283
oauth_user_info = _get_oauth_user_info
83-
84+
8485
SECURITY_MANAGER_CLASS = PluralSecurityManager
8586

8687
SQLALCHEMY_DATABASE_URI = conf.get('core', 'SQL_ALCHEMY_CONN')
87-
88+
8889
AUTH_TYPE = AUTH_OAUTH
89-
90+
9091
# registration configs
9192
AUTH_USER_REGISTRATION = True # allow users who are not already in the FAB DB
9293
AUTH_USER_REGISTRATION_ROLE = "Admin" # this role will be given in addition to any AUTH_ROLES_MAPPING
@@ -112,7 +113,7 @@ airflow:
112113
}
113114
}
114115
]
115-
116+
116117
# force users to re-auth after 30min of inactivity (to keep roles in sync)
117118
PERMANENT_SESSION_LIFETIME = 1800
118119
{{ end }}
@@ -129,7 +130,7 @@ airflow:
129130
airflow:
130131
config:
131132
AIRFLOW__WEBSERVER__BASE_URL: https://{{ $hostname }}
132-
{{ if eq .Provider "google" }}
133+
{{ if $isGcp }}
133134
AIRFLOW__LOGGING__REMOTE_BASE_LOG_FOLDER: "gs://{{ .Values.airflowBucket }}/airflow/logs"
134135
{{ end }}
135136
{{ if or (eq .Provider "aws") (eq .Provider "azure") (eq .Provider "kind") }}
@@ -138,8 +139,8 @@ airflow:
138139
{{ if or (eq .Provider "azure") (eq .Provider "kind") }}
139140
AIRFLOW__LOGGING__REMOTE_LOG_CONN_ID: minio
140141
{{ end }}
141-
142-
{{ if eq .Provider "google" }}
142+
143+
{{ if $isGcp }}
143144
connections:
144145
## see docs: https://airflow.apache.org/docs/apache-airflow-providers-google/stable/connections/gcp.html
145146
- id: plural
@@ -180,7 +181,7 @@ airflow:
180181
{{ end }}
181182

182183
serviceAccount:
183-
{{ if eq .Provider "google" }}
184+
{{ if $isGcp }}
184185
create: false
185186
{{ end }}
186187
annotations:

argo-workflows/helm/argo-workflows/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: argo-workflows
33
description: A Helm chart for Kubernetes
44
type: application
5-
version: 0.1.28
5+
version: 0.1.29
66
appVersion: "v3.2.9"
77
dependencies:
88
- name: argo-workflows

argo-workflows/helm/argo-workflows/values.yaml.tpl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{ $isGcp := or (eq .Provider "google") (eq .Provider "gcp") }}
12
{{- if .OIDC }}
23
oidcSecret:
34
clientID: {{ .OIDC.ClientId }}
@@ -79,7 +80,7 @@ artifactRepository:
7980
name: minio-secret
8081
key: secret-key
8182
{{ end }}
82-
{{ if eq .Provider "google" }}
83+
{{ if $isGcp }}
8384
gcs:
8485
bucket: {{ .Values.workflowBucket | quote }}
8586
{{ end }}
@@ -99,7 +100,7 @@ serviceAccount:
99100
annotations:
100101
eks.amazonaws.com/role-arn: "arn:aws:iam::{{ .Project }}:role/{{ .Cluster }}-argo-workflows"
101102
{{- end }}
102-
{{ if eq .Provider "google" }}
103+
{{ if $isGcp }}
103104
annotations:
104105
iam.gke.io/gcp-service-account: {{ importValue "Terraform" "service_account_email" }}
105106
{{ end }}

bootstrap/helm/bootstrap/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ maintainers:
1010
1111
- name: David van der Spek
1212
13-
version: 0.8.71
13+
version: 0.8.72
1414
dependencies:
1515
- name: external-dns
1616
version: 6.14.1

bootstrap/helm/bootstrap/templates/defaultstorageclass.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66
labels: {{ include "bootstrap.labels" . | nindent 4 }}
77
spec:
88
name: ebs-csi
9-
{{- else if eq .Values.provider "google" }}
9+
{{- else if or (eq .Values.provider "google") (eq .Values.provider "gcp") }}
1010
apiVersion: platform.plural.sh/v1alpha1
1111
kind: DefaultStorageClass
1212
metadata:

bootstrap/helm/bootstrap/templates/snapshot.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ metadata:
77
snapshot.storage.kubernetes.io/is-default-class: "true"
88
driver: ebs.csi.aws.com
99
deletionPolicy: Delete
10-
{{- else if eq .Values.provider "google" }}
10+
{{- else if or (eq .Values.provider "google") (eq .Values.provider "gcp") }}
1111
apiVersion: snapshot.storage.k8s.io/v1
1212
kind: VolumeSnapshotClass
1313
metadata:

bootstrap/helm/bootstrap/values.yaml.tpl

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{ $isGcp := or (eq .Provider "google") (eq .Provider "gcp") }}
12
{{ $pluraldns := .Network.PluralDns }}
23
{{ $providerArgs := dict "provider" .Provider "cluster" .Cluster }}
34
{{ if eq .Provider "google" }}
@@ -10,6 +11,8 @@ external-dns:
1011
extraArgs:
1112
plural-cluster: {{ $providerArgs.cluster }}
1213
plural-provider: {{ $providerArgs.provider }}
14+
{{ else if $isGcp }}
15+
provider: google
1316
{{ else }}
1417
provider: {{ .Provider }}
1518
{{ end }}
@@ -21,7 +24,7 @@ external-dns:
2124
rbac:
2225
create: true
2326
serviceAccount:
24-
{{ if eq .Provider "google" }}
27+
{{ if $isGcp }}
2528
create: false
2629
{{ end }}
2730
name: {{ default "external-dns" .Values.externaldns_service_account }}
@@ -31,7 +34,7 @@ external-dns:
3134
{{- end }}
3235
domainFilters:
3336
- {{ .Network.Subdomain }}
34-
{{- if eq .Provider "google" }}
37+
{{- if $isGcp }}
3538
google:
3639
project: {{ .Project }}
3740
{{- end }}
@@ -85,8 +88,8 @@ regcreds:
8588
provider: {{ .Provider }}
8689
ownerEmail: {{ .Config.Email }}
8790

88-
{{ if eq (default "google" .Provider) "aws" }}
89-
{{- if not .Values.disable_cluster_autoscaler }}
91+
{{ if eq .Provider "aws" }}
92+
{{- if not .Values.disable_cluster_autoscaler }}
9093
cluster-autoscaler:
9194
enabled: true
9295
awsRegion: {{ .Region }}
@@ -179,7 +182,7 @@ dnsSolver:
179182
environment: AzurePublicCloud
180183
{{ end }}
181184

182-
{{ if eq .Provider "google" }}
185+
{{ if $isGcp }}
183186
cert-manager:
184187
serviceAccount:
185188
create: false

chatwoot/helm/chatwoot/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apiVersion: v2
22
name: chatwoot
33
description: Open-source customer engagement suite, an alternative to Intercom, Zendesk, Salesforce Service Cloud etc.
44
type: application
5-
version: 0.1.7
5+
version: 0.1.8
66
appVersion: v2.15.0
77
dependencies:
88
- name: chatwoot

chatwoot/helm/chatwoot/values.yaml.tpl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{ $isGcp := or (eq .Provider "google") (eq .Provider "gcp") }}
12
{{- $redisNamespace := namespace "redis" }}
23
{{ $redisValues := .Applications.HelmValues "redis" }}
34
global:
@@ -8,7 +9,7 @@ global:
89

910
chatwoot:
1011
serviceAccount:
11-
{{- if eq .Provider "google" }}
12+
{{- if $isGcp }}
1213
create: false
1314
{{- end }}
1415
name: chatwoot
@@ -41,7 +42,7 @@ chatwoot:
4142
ACTIVE_STORAGE_SERVICE: amazon
4243
S3_BUCKET_NAME: {{ .Values.chatwootBucket }}
4344
AWS_REGION: {{ .Region }}
44-
{{- else if eq .Provider "google" }}
45+
{{- else if $isGcp }}
4546
ACTIVE_STORAGE_SERVICE: google
4647
GCS_PROJECT: {{ .Project }}
4748
GCS_BUCKET: {{ .Values.chatwootBucket }}

0 commit comments

Comments
 (0)