[aws-bootstrap] plural destroy fails to destroy Terraform resources

[tusharm]

Summary

Running plural destroy on aws-bootstrap always fails with this Terraform error:

│ Error: Unsupported attribute
│
│   on aws-bootstrap/locals.tf line 6, in locals:
│    6:     worker_private_subnet_ids = var.create_cluster ? module.vpc.worker_private_subnets_ids : var.worker_private_subnet_ids
│     ├────────────────
│     │ module.vpc is object with 98 attributes
│
│ This object does not have an attribute named "worker_private_subnets_ids".

I get the same error if I manually try terraform destroy inside bootstrap/terraform directory in the workspace.

Just to get to the root cause, I set create_cluster to false and then it makes a little progress but fails again further along. Not sure but I suspect create_cluster set to true is causing issue related to resource ordering when destroying.

Reproduction

I can replicate it with these commands:

$> plural bundle install kafka aws-kafka
...
$> plural bundle install console console-aws
...
$> plural build
..
$> plural deploy
...
$> plural destroy

UI/UX Issue Screenshots

Additional Info about Your Environment

PLURAL CLI:
   version	0.6.8
   git commit	308cf3858b8d26dd5a7c93613bbbf2879d8372b8
   compiled at	2023-02-24T19:18:19Z
   os/arch	darwin/arm64

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We factor engagement into prioritization.

[michaeljguarino]

Thanks for the report, we'll try to get this figured out soon. It's odd, because I'm pretty sure we have done some successful destroys recently

[davidspek]

@tusharm Are you still running into this issue? I did 6 cycles of creating and destroying clusters and wasn't able to replicate it. So if you are still running into this I would love to setup a call so we can further debug this.

[tusharm]

Thanks @davidspek, let me know how to schedule.

[LiamBrenner]

I've just had the same issue when trying to destroy, I noticed some references to a worker_private_subnets_ids variable, and other references to a worker_private_subnet_ids variable, is it possible the wrong variable name has been used somewhere?