Fix mergo configs (#663)

michaeljguarino · web-flow · commit 184ff00903e1 · 2025-08-28T13:53:15.000-04:00
I think the slice deep copy behavior has some goofy side-effects
diff --git a/pkg/pr/updates.go b/pkg/pr/updates.go
@@ -144,7 +144,7 @@ func mergeYaml(base, overlay []byte, merge ListMerge) ([]byte, error) {
 		return nil, err
 	}
 
-	options := []func(*mergo.Config){mergo.WithOverride, mergo.WithSliceDeepCopy}
+	options := []func(*mergo.Config){mergo.WithOverride}
 	if strings.ToUpper(string(merge)) == ListMergeAppend {
 		options = append(options, mergo.WithAppendSlice)
 	}

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ func mergeYaml(base, overlay []byte, merge ListMerge) ([]byte, error) {`
`144`	`144`	`return nil, err`
`145`	`145`	`}`
`146`	`146`
`147`		`- options := []func(*mergo.Config){mergo.WithOverride, mergo.WithSliceDeepCopy}`
	`147`	`+ options := []func(*mergo.Config){mergo.WithOverride}`
`148`	`148`	`if strings.ToUpper(string(merge)) == ListMergeAppend {`
`149`	`149`	`options = append(options, mergo.WithAppendSlice)`
`150`	`150`	`}`