feat: Add Git SSH preflight checks (#677)

* add Git SSH preflight checks

* fix message format

Author: maciaszczykm

pkg/client/plural.go

@@ -5,7 +5,7 @@ import (
 	"os"
 	"strings"
 
-	"github.com/pluralsh/plural-cli/pkg/utils/git"
+	gitutils "github.com/pluralsh/plural-cli/pkg/utils/git"
 	"github.com/pluralsh/polly/algorithms"
 	"github.com/samber/lo"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -105,6 +105,11 @@ func (p *Plural) HandleInit(c *cli.Context) error {
 	repo := ""
 	p.InitPluralClient()
 
+	git, err := wkspace.Preflight()
+	if err != nil && git {
+		return err
+	}
+
 	if utils.Exists("./workspace.yaml") {
 		utils.Highlight("Found workspace.yaml, skipping init as this repo has already been initialized\n")
 		utils.Highlight("Checking domain...\n")
@@ -118,7 +123,7 @@ func (p *Plural) HandleInit(c *cli.Context) error {
 			}
 		}
 		utils.Highlight("Domain OK \n")
-		branch, err := git.CurrentBranch()
+		branch, err := gitutils.CurrentBranch()
 		if err != nil {
 			return err
 		}
@@ -133,11 +138,6 @@ func (p *Plural) HandleInit(c *cli.Context) error {
 		return nil
 	}
 
-	git, err := wkspace.Preflight()
-	if err != nil && git {
-		return err
-	}
-
 	if err := common.HandleLogin(c); err != nil {
 		return err
 	}

pkg/wkspace/validator.go

@@ -5,9 +5,11 @@ import (
 	"fmt"
 	"os"
 	"os/exec"
+	"strings"
 
 	"github.com/pluralsh/plural-cli/pkg/executor"
 	"github.com/pluralsh/plural-cli/pkg/utils"
+	"github.com/pluralsh/plural-cli/pkg/utils/git"
 )
 
 func Preflight() (bool, error) {
@@ -17,13 +19,14 @@ func Preflight() (bool, error) {
 			return true, utils.HighlightError(fmt.Errorf("%s not installed", req))
 		}
 	}
-	fmt.Print("\nTesting if git ssh is properly configured...\n")
+
+	fmt.Print("\nTesting if git ssh is properly configured...")
 	if err := checkGitSSH(); err != nil {
 		fmt.Printf("%s\n\n", err.Error())
 		utils.Warn("Please ensure that you have ssh keys set up for git and that you've added them to your ssh agent. You can use `plural crypto ssh-keygen` to create your first ssh keys then upload the public key to your git provider.\n")
 		return true, fmt.Errorf("git ssh is not properly configured")
 	}
-	fmt.Println(" \033[32m (\u2713) \033[0m") // (✔)
+	fmt.Printf(" \033[32m (\u2713) \033[0m\n\n")
 
 	cmd := exec.Command("git", "rev-parse", "--is-inside-work-tree")
 	if _, err := cmd.CombinedOutput(); err != nil {
@@ -40,6 +43,18 @@ func Preflight() (bool, error) {
 		return true, utils.HighlightError(fmt.Errorf("repository has no remotes set, make sure that at least one remote is set"))
 	}
 
+	url, err := git.GetURL()
+	if err != nil {
+		return true, err
+	}
+
+	if strings.HasPrefix(url, "http") {
+		utils.Error("Found non-ssh upstream url %s, please reclone the repo with SSH and retry.\n", url)
+		utils.Warn("Please ensure that you have SSH keys set up for Git and that you've added them to your SSH agent.\n")
+		utils.Warn("You can use `plural crypto ssh-keygen` to create your first SSH keys then upload the public key to your Git provider.\n")
+		return true, fmt.Errorf("found non-ssh upstream")
+	}
+
 	return true, nil
 }